GNOME Bugzilla – Bug 449735
Various gdmsetup bugs
Last modified: 2010-06-04 20:16:38 UTC
Please describe the problem: This bug contains selection of problems that i have spotted whilst working on gdmsetup. they should be fixed in the upcomming patch for bug #404891 Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Yes Other information: list of bugs: 1. Logo filechooser/checbox do not work properly in local/remote plain greeter. Both share the same config value - changing file name in one of the filechooser does not update the other. Also changing the value in remote plain greeter and unticking and then ticking the checkbox saves filename selected in the local greeter rather than the one in the remote one. 2. Use24HrClock list selection does not display correct config values. auto and yes are both being displayed as auto
3. This is regarding translated/locale GDM_DEFAULT_WELCOME_MSG and GDM_DEFAULT_REMOTE_WELCOME_MSG config entries. When those values are being saved gdmsetup removes the locale bit from the key and saves it as a normal non-locale entry (gui/gdmsetup.c:greeter_entry_untranslate_timeout). Wouldn't it be better if the strings were saved as a current system locale strings (if different to the existing config values)?
Hmm regarding comment #3 gdm_config_get_translated_string seems to determine the locale of the string by selecting the first existing config entry from the list of existing locale, so maybe there is not much point in seting the translated string to the current one but re-use given locale (if exists)
Regarding comment #3. gdmsetup should either support the ability to add/edit/remove default messages per locale, or it should *only* allow the user to edit the non-locale version of the string. I thought the way it worked was to only allow users to edit the non-locale version of the string. If this is broken, we should fix it. Sounds like issues #1 and #2 are bugs. Will you be fixing these?
Regarding comment #3 Yes and no. When the entry widget is set up gdm_config_get_translated_string is called which iterates through locale (obtained via g_get_language_names) and returns first found occurrence of the translated key (or a normal key in case there is no translated equivalent). Then when the value is saved (greeter_entry_untranslate_timeout) it looks for locale versions of that key, removes all of them and then saves the value under non-locale key. This seems quite convoluted. Shouldn't we be removing only the translated string that was used in the first place (rather than all of them)? As for #1 and #2 this has been fixed already (in the upcoming patch)
Ah what if we add little pull down box which will list locale strings available in the config and allow users to define which string they want to modify?
That would be a nice way to fix the problem, I think.
Oki doki lets add this as a new feature reuqest. The current patch is long overdue and getting bigger and bigger. So i would like to finish it (i will make the translated strings work the exact way as they did in the past for time being) and close the appropriate bug. Bug #4 The remove button does not get de-sensitised when the user selection is removed from the treeview in xserver login window preferences dialog. Steps to reproduce: Select a server in the treeview - remove button becomes sensitive. De-select this item (makeng sure there is no other selected items) - the button does not becomes un-sensitive.
Looking forward to your patch.
Bug #5 This concerns Plain greeter in the Local tab and Same as Local in the Remote Tab. The Behaviour section in the Remote tab is active and allows overriding the config values set in the Local Tab. Additionally the visual feedback of widgets is not synchronised (i.e. checking a checkbox in the Local tab does not check the equivalent checkbox in the Remote tab (Same as Local remote greeter). The feedback bug affects all the checkboxes/spinbuttons in the Behaviour tab and the Background image FilechooserButton.
Is a patch coming?
All the issues have been fixed in the patch for bug #404891
*** This bug has been marked as a duplicate of 404891 ***
Thanks for taking the time to report this bug. However, you are using a version that is too old and not supported anymore. GNOME developers are no longer working on that version, so unfortunately there will not be any bug fixes for the version that you use. By upgrading to a newer version of GNOME you could receive bug fixes and new functionality. You may need to upgrade your Linux distribution to obtain a newer version of GNOME. Please feel free to reopen this bug if the problem still occurs with a newer version of GNOME.