After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 449171 - [verified] Orca gets stuck in endless loops on woot.com
[verified] Orca gets stuck in endless loops on woot.com
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.19.x
Other All
: Normal major
: 2.20.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2007-06-19 15:56 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-07-22 19:27 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
patch to hopefully solve the problem (4.24 KB, patch)
2007-06-19 16:06 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review
patch for another instance of the false assumption re document frames (962 bytes, patch)
2007-06-19 17:52 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2007-06-19 15:56:30 UTC 
Steps to reproduce:

1. Navigate to woot.com
2. Try to navigate heading by heading by pressing H.  After you get to side deals, Orca hangs

1. Navigate to woot.com
2. Double-click whereAmI to get the page summary.  Depending on your location when you do this, Orca hangs.

Looking at this in Accerciser, there are two document frames; not one.  Orca's find{Next, Previous}Object() assume only one.
Comment 1 Joanmarie Diggs (IRC: joanie) 2007-06-19 16:06:18 UTC 
Created attachment 90276 [details] [review]
patch to hopefully solve the problem

This patch removes the assumption that we have a single document frame from find{Next,Previous}Object().  Rather than comparing obj et al. to the document frame by role, compare it to what is returned by self.getDocumentFrame().

Mike please test.
Comment 2 Mike Pedersen 2007-06-19 16:16:36 UTC 
Seems to work great.  Thanks much
Comment 3 Joanmarie Diggs (IRC: joanie) 2007-06-19 16:17:59 UTC 
Will please review.
Comment 4 Willie Walker 2007-06-19 16:58:57 UTC 
Looks good.  Nice fix.  :-)
Comment 5 Joanmarie Diggs (IRC: joanie) 2007-06-19 17:07:15 UTC 
Thanks Will.  Patch committed.  Changing status to "pending."
Comment 6 Joanmarie Diggs (IRC: joanie) 2007-06-19 17:52:30 UTC 
Created attachment 90284 [details] [review]
patch for another instance of the false assumption re document frames

While trying to get to the bottom of this bug, I noticed that Orca could not arrow past the Go button.  It turns out it's another case of our assuming that there's just one document frame -- this time in find{Next,Previous}CaretInOrder().

Will, okay to check this in?
Comment 7 Willie Walker 2007-06-19 18:16:29 UTC 
Absolutely fabulous.  Please commit!  :-)
Comment 8 Joanmarie Diggs (IRC: joanie) 2007-06-19 18:30:12 UTC 
Done.  Thanks!
Comment 9 Mike Pedersen 2007-06-20 18:16:35 UTC 
seems good now
Comment 10 Joanmarie Diggs (IRC: joanie) 2007-06-20 18:44:15 UTC 
Thanks.  Closing as FIXED.