GNOME Bugzilla – Bug 449152
[verified] Cannot create a new message in thunderbird while using orca
Last modified: 2008-07-22 19:27:48 UTC
1. from within thunderbird press CTRL+N to create a new message. At this point you will observe the following problems: 1. Orca speaks no role information for either the to field or the message boddy. 2. Orca does not allow alphanumeric keys to e used in the subject field. Orca attempts to perform structural navigation. 3. No labels are spoken for the to field or the message boddy.
Thunderbird is not on our radar screen now, so I question the target of GNOME 2.19.90. Is this a generic bug or is it isolated to Thunderbird?
I'm not sure. I would bet that it is a mozilla bug. The reason I put that target is just so we'd file the appropriate mozilla bug if necessary sooner than later.
w.r.t. > 2. Orca does not allow alphanumeric keys to e used in the subject field. Orca > attempts to perform structural navigation. As you type a subject, the text appears not only in the subject entry but also in the name of the frame containing the message. This is triggering events such as: vvvvv PROCESS OBJECT EVENT object:visible-data-changed vvvvv OBJECT EVENT: object:visible-data-changed detail=(0,0) app.name='Thunderbird' name='Compose: t' role='frame' state='ACTIVE ENABLED RESIZABLE SENSITIVE SHOWING VISIBLE' relations='' ^^^^^ PROCESS OBJECT EVENT object:visible-data-changed ^^^^^ Thunderbird.py doesn't have its own onVisibleDataChanged(), so the one in Gecko.py kicks in. Seems that the conditions that resemble switching tabs in Firefox. So we can try to do some extra checking in Gecko.py or we can just override it in Thunderbird.py. Personally I'm leaning towards overriding it for now (and just returning). Will, what do you think? On to issues 1 and 3....
Regarding issue 3: There are no labels to be spoken. The To (and CC and BCC and everything but the subject and the message body) have as their functional label a combo box on the left. Will: Is it kosher for there to be a labelled_by relationship pointing to an object that is NOT of role ROLE_LABEL? If so, I can file a bug requesting that. The body of the message is a document frame with the name about:blank. I can request a better name there as well. :-)
Regarding issue 1: We're not speaking the roles because Thunderbird.py's onFocus() contains the following: # Let onTextInsertion handle autocompletion. # if parent and parent.role == rolenames.ROLE_AUTOCOMPLETE: return Comment those lines out and we do speak the roles. Having commented them out, I also didn't notice any changes in Orca's behavior in Thunderbird. Lynn is this something you added? If so, do you recall why it was necessary? Thanks!
This is my code that's part of a fix for a bug where autocompletions were not spoken. The return statement is to avoid having the autocompletion spoken twice: once in onFocus and then again in onTextInserted. If autocompletions are no longer spoken twice, it can be safely removed.
> Will: Is it kosher for there to be a labelled_by relationship > pointing to an object that is NOT of role ROLE_LABEL? If so, I can file a bug > requesting that. Well...I'm not sure if a rabbi would approve, but I think it should be legal. > The body of the message is a document frame with the name > about:blank. I can request a better name there as well. :-) Either that, or we can just special case for "about:blank" as long as we're guaranteed that it will be the same across all locales.
Created attachment 90309 [details] [review] patch to do what we can Okay, this patch removes the handling of objects whose parent is an autocomplete from Thunderbird.py's onFocus(). Thanks for the info Lynn! I've also added an onVisibleDataChanged() which simply returns. I think this is easier and safer than trying to correctly distinguish these in Gecko.py. <waits for Will to say "nasty hack"> ;-) ;-) ;-) ;-) ;-) ;-) ;-) ;-) ;-) As for the not speaking of labels in the headers: I've requested that via filing a bug at mozilla: https://bugzilla.mozilla.org/show_bug.cgi?id=385121. In the meantime, while not ideal, one can identify the "label" via Shift+Tab'ing to the combo box that precedes the entry in question. Mike: Does this make creating a new message in Thunderbird more tolerable for now?
This is getting better. A couple things I'm still noticing: 1. We're still getting all that extra chatter when typing in the subject field. 2. When typing in the message body we don't seem to be honoring key echo. That's another bug for another time though. Thanks a lot for working on this.
I just tried it (again) and I'm not getting extra chatter when typing in the subject field and it is honoring key echo (I chose words) both in the subject field and in the message body. Are you using the latest Thunderbird?
I've just created a debug file which I'll send to you in email as it is pretty large.
After getting a clean thunderbird tree I can nolonger reproduce the problem in the subject field. As this patch fixes the problems I reported and I can now create messages in thunderbird I'd say this patch is OK to check in.
Sounds good. Thanks! If the problem reappears, please let me know. In the meantime, the patch has been committed. Moving this to pending.