GNOME Bugzilla – Bug 449087
save buttons not working
Last modified: 2014-09-01 19:41:45 UTC
Original Ubuntu bug tracker page: https://bugs.launchpad.net/ubuntu/+source/meld/+bug/83733 Description: Cannot save changes until closing compared files tab. It appears the Save buttons aren't working. Steps to reproduce: 1. Create a file, make a copy, modify the copy slightly 2. Open meld to compare the two files 3. Merge the change from the second file to the first 4. Note the '*' in the title of the modified file. 5. Click the save toolbar button - note changes not saved 6. Click File > Save from the meny - changes not saved 7. Type Ctrl+s - changes not saved. 8. Click the X on the comparison tab, you'll get a prompt about unsaved changes and you can now save the modifications Other information: The reason the buttons are working is because the mouse/cursor focus isn't on the file which has changed. It's probably on neither, so when the save button is clicked it doesn't know which file should be changed and so does nothing. By clicking the in the file you want to save it gains focus and the save buttons work.
I can confirm this problem. $ dpkg -l meld ii meld 1.1.5.1-2ubuntu1 graphical tool to diff and merge files
I can reproduce, but that's known (Work As Designed) the save button, shortcut & key-combo work on the pane that has the focus, and guess what, merging (I assume you use the GUI arrows to merge) does not change the focus to the modified pane. Try clicking in the modified pane before saving and it should work. This is annoying, and there is another bug report about a similar problem... There could be a few ways to workaround the deficiency: * Save-all menu entry + shortcut + button. Does the obvious. OK, obvious, as in save-all-for-current-diff-tab. * In case only one pane is modified, just save that one as it is not ambiguous... * Give focus on "merging" (same as modifying the text manually) All of these could be implemented orthogonally...
Vincent, I like your idea to change the current meaning of the toolbar "save" button to "save all" and the single modified file heuristic as it's probably what most people want most of the time. There is still a context menu to save an individual file if that is needed.
Created attachment 132797 [details] [review] focus pane modified with linkmap button
http://bugzilla.gnome.org/show_bug.cgi?id=449087 https://bugs.launchpad.net/meld/+bug/83733 are probably the same bugs
How about having separate menu entries for left and right pane (and possibly middle pane) such as "Save Left", "Save Right"? Thus, I suggest the final layout to be like, File ---- New Comparison Save Left Save Middle -> Only if 3-pane comparison Save Right Save All Revert <Other Entries>
Sorry for double posting as there is no way to edit a comment. The layout suggested has these benefits:- 1) This will behave exactly as the user expects - even if he/she forgets which pane is having the focus. 2) This will work even if *none* of the panes is having the focus. Please share your views also.
This problem has been fixed in Meld 3.11 by adding save icons in the toolbar-like placeholder on the top of each file comparison. Thanks for the bug report.
*** Bug 735792 has been marked as a duplicate of this bug. ***