After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 447453 - Implicit pointer conversions will crash on 64-bits platform; _()
Implicit pointer conversions will crash on 64-bits platform; _()
Status: RESOLVED FIXED
Product: xchat-gnome
Classification: Other
Component: general
0.17
Other Linux
: Normal critical
: ---
Assigned To: xchat-gnome maintainers
xchat-gnome maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-14 09:52 UTC by Loïc Minier
Modified: 2007-07-07 20:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix implicit pointer conversions of _() calls (904 bytes, patch)
2007-06-14 09:53 UTC, Loïc Minier
none Details | Review

Description Loïc Minier 2007-06-14 09:52:15 UTC
Hi,

Dann Frazier reported in Debian bug http://bugs.debian.org/428459:
"""
Our automated buildd log filter[1] detected a problem that is likely to
cause your package to segfault on architectures where the size of a
pointer is greater than the size of an integer, such as ia64 and amd64.

This is often due to a missing function prototype definition.

The following patch replaces '_(...)' with 'gettext(...)' along with
the intltool definition. I'm guessing that this has the intended
functionality, but I could be wrong - I'm not too familiar with
l10n functionality.

[1]http://people.debian.org/~dannf/check-implicit-pointer-functions

----- Forwarded message from Build Daemon <buildd@excelsior.roeckx.be> -----

X-Spam-Checker-Version: SpamAssassin 3.1.7-deb (2006-10-05) on ldl.fc.hp.com
X-Spam-Level:
X-Spam-Status: No, score=-1.3 required=3.5 tests=AWL,BAYES_00,UNDISC_RECIPS
        autolearn=disabled version=3.1.7-deb
X-Virus-Scanned: Debian amavisd-new at ldl.fc.hp.com
Subject: Log for successful build of xchat-gnome_1:0.17-1 (dist=unstable)
Date: Mon, 11 Jun 2007 11:53:39 +0000 (GMT)
From: Build Daemon <buildd@excelsior.roeckx.be>
To: undisclosed-recipients: ;
X-PMX-Version: 5.3.1.294258, Antispam-Engine: 2.5.1.298604, Antispam-Data:
2007.6.11.43145
Debian-Buildd-Error: Yes

Function `_' implicitly converted to pointer at python.c:2081
Function `_' implicitly converted to pointer at tclplugin.c:2218

----- End forwarded message -----
"""

He provided a patch to include <libintl.h> and call gettext() instead of _() in these files, but I went for glib-gettext like in the rest of the codebase.

Bye,
Comment 1 Loïc Minier 2007-06-14 09:53:28 UTC
Created attachment 89937 [details] [review]
Fix implicit pointer conversions of _() calls
Comment 2 David Trowbridge 2007-07-07 20:36:28 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.