GNOME Bugzilla – Bug 443716
Move evolution-addressbook-export to e-d-s
Last modified: 2016-06-24 10:38:43 UTC
Since evolution-addressbook-export is useful for those who use e-d-s but not evo, it should be moved to the e-d-s source tree. If I get a 'thumbs up' for this, I'll craft a patch..
I'm fine with that, especially if that means that the odd linking to libedataserverui disappears. I suggest moving it to evolution-data-server/addressbook/tools/
Created attachment 89709 [details] [review] Remove addressbook/tools from evolution
Created attachment 89710 [details] [review] Add addressbook/tools from evolution It does indeed remove the libedataserverui linkage. It probably happened because addressbook's CFLAGS and LIBS was reused. Now, in e-d-s, I had to make a dedicated DEPS because e-d-s's addressbook didn't already have the necessary deps.
Comment on attachment 89710 [details] [review] Add addressbook/tools from evolution The patch contains generated files such as Makefile.in. Also please don't explicitly depend on and use Bonobo unless it is essential, in this case it isn't (simply removing it from the depends and includes will fix that). Also please remove the libgnomeui dependency, making it a pure Glib application. Using gnome-program forces its use inside an X session I believe.
Still valid in 3.2.3
Is this export tool actually useful to anyone these days? It gets virtually no attention from developers.
Please do not remove it. I use it in a daily cron job to export my contacts to vcard files so I can track the changes in a git repository. I use the --list-addressbook-folders option to remind me to add new address books to the cron job. I don't mind if it moves to e-d-s though, since evolution depends on that.
I moved it to eds, and made some other more or less related changes in the code. The file is placed in $PREFIX/libexec/evolution-data-server and its name is addressbook-export. The csv2vcard script left as it was, only its folder changed too. Otherwise didn't change anything. Created commit_63b603a in eds master (3.21.4+) [1] Created commit c0f5f33 in evo master (3.21.4+) [1] https://git.gnome.org/browse/evolution-data-server/commit/?id=63b603a