GNOME Bugzilla – Bug 442888
problem with GTK+ medialib integration
Last modified: 2007-06-07 04:44:19 UTC
Recently, the patches for bug #344813 went into GTK+ to add mediaLib support. However, I caught one bug in this code. The gdk/gdkmedialib.h file isn't being included in the distribution tarballs because the gtkmedialib.h file is only being added to gdk_headers if USE_MEDIALIB is turned on. Instead, this header file should always be included in the distribution tarball. Otherwise, the build fails because of this missing header when USE_MEDIALIB is on. The attached minor patch to gdk/Makefile.am fixes this problem. Can this go upstream? I've tested this and verified that when I run "make dist" it includes the gdk/gdkmedialib.h file in the tarball.
Created attachment 89178 [details] [review] patch fixing the problem
Given that _gdk_use_medialib() is underscore-prefixed, it is not exported from the library anyway, so installing that header makes no sense. And adding it to gdk_headers installs it, so a better fix might be to add it to EXTRA_DIST either directly, or indirectly, by introducing some gdk_private_headers variable like we have in gtk/Makefile.am.
Created attachment 89378 [details] [review] updated patch Thanks for the comments. This patch moves gdkmedialib.h to EXTRA_DIST instead. Can this go upstream?
Looks fine.
Thanks. Can I commit, or will you?
If you can do it, please go ahead.
This breaks the build: gdk_headers: variable `medialib_h_sources' is used but `medialib_h_sources' is undefined I guess the right fix is to remove the remaining reference to that variable?
Fixed earlier today
I'm really sorry about breaking the build. Thanks for correcting this Matthias.