After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 442689 - [neon] Property-related cleanups of neonhttpsrc
[neon] Property-related cleanups of neonhttpsrc
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal blocker
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-31 20:33 UTC by René Stadler
Modified: 2007-06-01 09:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Cleanup neonhttpsrc element properties (3.07 KB, patch)
2007-05-31 20:34 UTC, René Stadler 		committed Details | Review

Description René Stadler 2007-05-31 20:33:30 UTC 
- I don't understand why the element has a deprecated property (uri), it is still in -bad so it can break API.

 - The user-agent default value is plain "neonhttpsrc", which doesn't give anybody a clue out of context.  It should at least mention GStreamer in there.

 - There are some more or less serious formatting/spelling/style/expression problems in some property descriptions, like explaining in full what a HTTP URL can look like (using newlines and tabs to make the novel line up in gst-inspect).

Marking as blocker for the release since I think that the deprecated property should die rather sooner than later.  Attaching trivial patch.
Comment 1 René Stadler 2007-05-31 20:34:39 UTC 
Created attachment 89133 [details] [review]
Cleanup neonhttpsrc element properties

Changes:

        * ext/neon/gstneonhttpsrc.c (gst_neonhttp_src_class_init): Remove
        deprecated "uri" property.  Clean up property descriptions.
        
        (gst_neonhttp_src_init): Change default User-Agent to the slightly more
        descriptive "GStreamer neonhttpsrc".
Comment 2 Wim Taymans 2007-06-01 09:57:35 UTC 
        Patch by René Stadler <mail at renestadler dot de>:

        * ext/neon/gstneonhttpsrc.c: (gst_neonhttp_src_class_init),
        (gst_neonhttp_src_init), (gst_neonhttp_src_dispose),
        (gst_neonhttp_src_set_property), (gst_neonhttp_src_get_property),
        (gst_neonhttp_src_start), (gst_neonhttp_src_do_seek),
        (gst_neonhttp_src_set_location),
        (gst_neonhttp_src_send_request_and_redirect),
        (gst_neonhttp_src_uri_get_uri), (gst_neonhttp_src_uri_set_uri):
        * ext/neon/gstneonhttpsrc.h:
        Deprecated "uri" property.  Clean up property descriptions.
        Change default User-Agent to the slightly more descriptive
        "GStreamer neonhttpsrc".
        Various other small cleanups, mostly property related.