GNOME Bugzilla – Bug 441343
AtkValue needs manual proxy methods
Last modified: 2013-08-26 13:08:41 UTC
The AtkValue interface needs manual proxy overrides to account for the outbound GValue parameters and the fact that AT-SPI only supports doubles in this field anyways.
Created attachment 88831 [details] [review] manual proxies for all AtkValue methods
Looks good but PyGtk hasn't branched yet.
Thanks. Again, this patch can wait. I didn't know that svn was frozen.
Feel free to branch of 2.10.x and commit your changes to trunk.
I'm assuming you were talking to Gustavo, not me, the non-pygtk devel, right? :)
(In reply to comment #5) > I'm assuming you were talking to Gustavo, not me, the non-pygtk devel, right? > :) > No, both of you. If you have a gnome svn account know how to branch, I don't see why you couldn't do it.
Oh. OK. Then let me make sure I understand what you're saying. > Feel free to branch of 2.10.x and commit your changes to trunk. You want me to create a 2.10 branch, then apply these patches to trunk? Or do you want me to branch from trunk or another existing branch, work in that new branch, and then merge into trunk when done?
(In reply to comment #7) > Oh. OK. Then let me make sure I understand what you're saying. > > > Feel free to branch of 2.10.x and commit your changes to trunk. > > You want me to create a 2.10 branch, then apply these patches to trunk? Or do > you want me to branch from trunk or another existing branch, work in that new > branch, and then merge into trunk when done? > You can't API to 2.10, which is the current trunk. So you need to create a new branch which is API compatible in case we want to do another 2.10.x release. Once that is done you can commit your changes to trunk which will be used to release 2.12.x.
What's the preferred naming scheme? pygtk-2-10? Or something specific to the work I'm doing like pygtk-atk?
Since it's for 2.10 and by looking at http://svn.gnome.org/viewcvs/pygtk/branches/, pygtk-2-10.
I'm tired of silly question: gjc@nazgul:pygtk$ svn cp -m "branch for 2.10" svn+ssh://gjc@svn.gnome.org/svn/pygtk/trunk svn+ssh://gjc@svn.gnome.org/svn/pygtk/branches/pygtk-2-10 Committed revision 2823. Now go commit your stuff to trunk :)
Closing this bug as obsolete. In the same way, the patch is wrong as is wrapping AtkValue, but receiving an AtkComponent as *self.