After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 441157 - metadata reader times out when an error has been sent on the bus
metadata reader times out when an error has been sent on the bus
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Importing
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-25 11:11 UTC by Jonathan Matthew
Modified: 2007-05-28 12:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.95 KB, patch)
2007-05-25 11:12 UTC, Jonathan Matthew 		none Details | Review
fix two leaks (3.48 KB, patch)
2007-05-28 11:01 UTC, James "Doc" Livingston 		committed Details | Review

Description Jonathan Matthew 2007-05-25 11:11:35 UTC 
The metadata reader waits 5 seconds for the state change to PAUSED to complete, during which time it isn't handling bus messages.  In some cases, we get an error and the state change doesn't complete, so the metadata reader pointlessly stalls for up to 5 seconds.

Simple test case:
cd metadata/
./rhythmbox-metadata --load file://`pwd`/rb-metadata-gst.c

should exit immediately, saying "this appears to be a text file".  Currently, it:
1) takes over 5s
2) crashes on exit (oops)
Comment 1 Jonathan Matthew 2007-05-25 11:12:52 UTC 
Created attachment 88789 [details] [review]
patch

fixes the crash and the slowness, doesn't seem to break successful metadata reading.
Comment 2 James "Doc" Livingston 2007-05-28 11:01:16 UTC 
Created attachment 88936 [details] [review]
fix two leaks

The patch looks good to me. This version fixes two memory leaks.
Comment 3 Jonathan Matthew 2007-05-28 12:35:26 UTC 
OK, committed (to trunk, at least).  Thanks for the memory leak fixes.