Bug 440377 – gnome-terminal cannot refresh terminal when accessibility enabled

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 440377 - gnome-terminal cannot refresh terminal when accessibility enabled


Summary:	gnome-terminal cannot refresh terminal when accessibility enabled


Status:	RESOLVED FIXED

Product:	vte
Classification:	Core
Component:	general
Version:	0.16.x
Hardware:	Other opensolaris

Importance:	Normal major
Target Milestone:	---
Assigned To:	VTE Maintainers
QA Contact:	VTE Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2007-05-22 07:59 UTC by Li Yuan
Modified:	2007-05-22 08:21 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
patch (540 bytes, patch) 2007-05-22 08:01 UTC, Li Yuan	committed	Details \| Review

Description Li Yuan 2007-05-22 07:59:21 UTC

1. enable accessibility and start gnome-terminal.
2. press ctrl+shift+t to open a new tab.
3. nothing shows in the new tab.

Comment 1 Li Yuan 2007-05-22 08:01:10 UTC

Created attachment 88582 [details] [review]
patch

Comment 2 Li Yuan 2007-05-22 08:01:49 UTC

Hi, is there anybody can help me to review the patch?

Comment 3 Chris Wilson 2007-05-22 08:10:26 UTC

Good catch, thanks. I've extended the patch to cover the other incorrect GdkEvent handlers.

r1892: 2007-05-22  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 440377 – gnome-terminal cannot refresh terminal when accessibility enabled
	Original patch by Li Yuan.

	* src/vteaccess.c (vte_terminal_accessible_focus_in),
	(vte_terminal_accessible_focus_out),
	(vte_terminal_accessible_visibility_notify):
	    Return FALSE rather than void...

Comment 4 Li Yuan 2007-05-22 08:21:56 UTC

Thank you! Can this patch get into gnome-2-18 branch?