After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 439480 - translations
translations
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkRecent
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
Emmanuele Bassi (:ebassi)
Depends on:
Blocks:
 
 
Reported: 2007-05-18 17:54 UTC by Morten Welinder
Modified: 2007-07-13 16:38 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Morten Welinder 2007-05-18 17:54:14 UTC
the recent-files code lacks translation in various places.

gtk_recent_chooser_default_add_filter:
    name = "Untitled filter";

gtk_recent_manager_real_changed:
          filename_warning ("Attempting to store changes into `%s', "
			    "but failed: %s",
			    priv->filename,
			    write_error->message);

          filename_warning ("Unable to stat() the recently used resources file "
			    "at `%s': %s.",
			    priv->filename,
			    g_strerror (errno));
[fixing the latter probably will make it necessary to save errno]

gtk_recent_manager_poll_timeout:
      filename_warning ("Unable to stat() the recently used resources file "
			"at `%s': %s.",
			priv->filename,
			g_strerror (errno));

build_recent_items_list:
          filename_warning ("Attempting to read the recently used resources file "
			    "at `%s', but an error occurred: %s. Aborting.",
			    priv->filename,
			    g_strerror (errno));

      filename_warning ("Attempting to read the recently used resources file "
			"at `%s', but the parser failed: %s.",
			priv->filename,
			read_error->message);


get_uri_shortname_for_display:
      name = g_strdup_printf ("%s: %s", method, local_file);
[rtl languages might want something else here.  some language might require
a space before the colon]

gtk_recent_chooser_menu_create_item:
      if (count <= 10)
        label = g_strdup_printf ("_%d. %s", count, escaped);
      else
        label = g_strdup_printf ("%d. %s", count, escaped);
[As above.  Also s/10/9/.]
Comment 1 Matthias Clasen 2007-07-13 16:37:55 UTC
I have handled the "Untitled filter" and "%d. %s" strings. I don't think the
"%s: %S" in get_uri_shortname_for_display needs to be translated, that is
just a fallback case.

I left out the errors, since I think we already have a bug about marking
error messages as translatable.

2007-07-13  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkrecentmanager.c (get_uri_shortname_for_display): Avoid
        gratitious use of g_strdup_printf().

        * gtk/gtkrecentchooserdefault.c:
        * gtk/gtkrecentchoosermenu.c: Mark some strings for
        translation.  (#439480, Murray Cumming)