After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 436204 - [Patch] Run gtk-update-icon-cache in uninstall-hook
[Patch] Run gtk-update-icon-cache in uninstall-hook
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: general
2.20.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-utils Maintainers
gnome-utils Maintainers
Depends on:
Blocks: 362604
 
 
Reported: 2007-05-05 21:04 UTC by Brian Pepple
Modified: 2008-01-08 23:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to run gtk-update-icon-cache in uninstall-hook (3.04 KB, patch)
2007-05-05 21:04 UTC, Brian Pepple 		none Details | Review
run gtk-update-icon-cache in uninstall-hook (2.33 KB, patch)
2007-10-07 16:20 UTC, Christian Kirbach 		none Details | Review
run gtk-update-icon-cache in (un)install-hook (2.04 KB, patch)
2008-01-05 17:28 UTC, Christian Kirbach 		committed Details | Review

Description Brian Pepple 2007-05-05 21:04:14 UTC 
In the theme-friendly-icons gnome goal:

  http://live.gnome.org/GnomeGoals/AppIcon

We made all apps run gtk-update-icon-cache in install-hook.  They also should
call it in uninstall-hook.
Comment 1 Brian Pepple 2007-05-05 21:04:52 UTC 
Created attachment 87625 [details] [review]
patch to run gtk-update-icon-cache in uninstall-hook
Comment 2 Kjartan Maraas 2007-10-03 12:18:17 UTC 
Can someone take a look at this and commit it if it's ok?
Comment 3 Christian Kirbach 2007-10-07 16:10:39 UTC 
Looks ok. to me but the code has changed, it does no longer apply at all.
Comment 4 Christian Kirbach 2007-10-07 16:20:11 UTC 
Created attachment 96832 [details] [review]
run gtk-update-icon-cache in uninstall-hook

applys cleanly again.

patch looks good to me.
Comment 5 Christian Kirbach 2008-01-05 17:26:49 UTC 
The changes to gnome-dictionary/data/Makefile.am are obsolete by now - removing the Changelog entry.
Comment 6 Christian Kirbach 2008-01-05 17:28:23 UTC 
Created attachment 102220 [details] [review]
run gtk-update-icon-cache in (un)install-hook

run gtk-update-icon-cache in (un)install-hook

removed the obsolete Changelog entry

I'd like to commmit this soon if there are no complaints
Comment 7 Emmanuele Bassi (:ebassi) 2008-01-05 19:08:02 UTC 
patch looks fine to me, commit it to trunk and to the stable branch please.
Comment 8 Kjartan Maraas 2008-01-08 23:46:20 UTC 
I commited this for you. Thanks.
Comment 9 Emmanuele Bassi (:ebassi) 2008-01-08 23:51:57 UTC 
thanks Kjartan, and thanks again Christian for the patch.