After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 435840 - GTK_WIDGET_SAVED_STATE inconsistency
GTK_WIDGET_SAVED_STATE inconsistency
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.10.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2007-05-04 14:30 UTC by Xan Lopez
Modified: 2007-06-13 14:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Testcase (1.78 KB, text/plain)
2007-05-04 14:31 UTC, Xan Lopez 		  Details
Tim's patch (2.43 KB, patch)
2007-05-07 12:45 UTC, Xan Lopez 		committed Details | Review
Automated testcase (1.84 KB, text/plain)
2007-05-23 13:00 UTC, Xan Lopez 		  Details

Description Xan Lopez 2007-05-04 14:30:44 UTC 
It seems the SAVED_STATE of a container and its children can get inconsistent in some situations. Example: GtkButton with an HBox containing an arrow and a label.
When you set the button insensitive from a callback on its clicked signal the save state for the button itself will be NORMAL, but the save state for its children (HBox, and logically Arrow and Label) will be ACTIVE. This leds to theming glitches in maemo where the actual graphics used are dependent on the widgets' state. Testcase attached.
Comment 1 Xan Lopez 2007-05-04 14:31:14 UTC 
Created attachment 87528 [details]
Testcase
Comment 2 Xan Lopez 2007-05-07 12:45:11 UTC 
Created attachment 87707 [details] [review]
Tim's patch

Discussed with Tim on jabber about this issue and he came up with this patch. It fixes the saved_state inconsistency.
Comment 3 Xan Lopez 2007-05-23 13:00:11 UTC 
Created attachment 88668 [details]
Automated testcase

First stab at an automated test case. It aborts with stock GTK+ and works fine with Tim's patch.
Comment 4 Tim Janik 2007-06-13 13:25:35 UTC 
rock! thanks Xan. bratsche/tbf, can we get this into SVN?
Comment 5 Cody Russell 2007-06-13 14:19:50 UTC 
Committed to trunk and gtk-2-10.