After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 434858 - Icons in the prefs tabs
Icons in the prefs tabs
Status: RESOLVED OBSOLETE
Product: gDesklets
Classification: Deprecated
Component: core
svn/bzr repository
Other Linux
: High normal
: ---
Assigned To: gDesklets Maintainers
gDesklets Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-01 11:34 UTC by Bjoern Koch
Modified: 2007-07-06 19:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Diff for config/ConfigDialog.py which introduces an icon attribute to the prefs tag (1.32 KB, text/plain)
2007-05-01 11:36 UTC, Bjoern Koch
Details

Description Bjoern Koch 2007-05-01 11:34:24 UTC
Find attached an improvement of config/ConfigDialog.py which introduces an icon attribute to the page tag which will show icons in der prefs tabs in front of the labels. The icons are downscaled in height (if necessary) to the size of the label keeping the aspect ratio.
Usage:
	<page label="My Label" icon="test.png">

Only problem so far: the icon has to be in the root directory (/) or its full path (like /home/user/.gdesklets/Displays/MyDesklet/test.png ) has to be given as the path to the display's directory is unknown to the ConfigDialog.
Some (minor) fixes need to be done in the core to fix this.
See the MailingList for more details.
Comment 1 Bjoern Koch 2007-05-01 11:36:35 UTC
Created attachment 87320 [details]
Diff for config/ConfigDialog.py which introduces an icon attribute to the prefs tag

The diff file.
Comment 2 Christian Meyer 2007-05-04 16:45:37 UTC
Nice!
Comment 3 Christian Meyer 2007-06-23 18:31:03 UTC
Bjoern, could you please commit your patch to the bzr repository? Thanks in advance!
Comment 4 Christian Meyer 2007-07-04 00:12:30 UTC
Bjoern, we gonna work on this. As discussed, it should go into v0.36.
Comment 5 Bjoern Koch 2007-07-05 00:05:14 UTC
The patch is in the bzr repository.
But it is still waiting for the ConfigDialog to be fixed so it knows the desklet's path.
I will open a new bug on LP as soon as the login problem on the bugs page has been solved.
Comment 6 Bjoern Koch 2007-07-06 19:57:49 UTC
"Moved" to LP a bug #124464.