GNOME Bugzilla – Bug 433703
[Patch] Run gtk-update-icon-cache in install-hook and uninstall-hook
Last modified: 2007-05-02 18:43:30 UTC
Please describe the problem: In the theme-friendly-icons gnome goal: http://live.gnome.org/GnomeGoals/AppIcon We made all apps run gtk-update-icon-cache in install-hook. They also should call it in uninstall-hook. Refer to #362604. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 87098 [details] [review] patch to run gtk-update-icon-cache in install-hook and uninstall-hook
Comment on attachment 87098 [details] [review] patch to run gtk-update-icon-cache in install-hook and uninstall-hook >Index: ChangeLog >=================================================================== >--- ChangeLog (revision 591) >+++ ChangeLog (working copy) >@@ -1,3 +1,8 @@ >+2007-04-26 David Farning <dfarning@gmail.com> >+ >+ * icons/Makefile.am (update-icon-cache): fix gtk-update-icon-cache >+ for install-hook and uninstall-hook. >+ > 2007-04-23 Jonh Wendell <jwendell@gnome.org> > > * server/vino-input.c: >Index: icons/Makefile.am >=================================================================== >--- icons/Makefile.am (revision 591) >+++ icons/Makefile.am (working copy) >@@ -1,4 +1,14 @@ > iconsdir = $(datadir)/icons/hicolor/48x48/apps > icons_DATA = gnome-remote-desktop.png >- >+gtk_update_icon_cache = gtk-update-icon-cache -f -t $(datadir)/icons/hicolor >+install-data-hook: update-icon-cache >+uninstall-hook: update-icon-cache >+update-icon-cache: >+ @-if test -z "$(DESTDIR)"; then \ >+ echo "Updating Gtk icon cache."; \ >+ $(gtk_update_icon_cache); \ >+ else \ >+ echo "*** Icon cache not updated. After (un)install, run this:"; \ >+ echo "*** $(gtk_update_icon_cache)"; \ >+ fi > EXTRA_DIST = $(icons_DATA)
Thanks, patch commited in svn.