After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 433694 - [Patch] Run gtk-update-icon-cache in uninstall-hook
[Patch] Run gtk-update-icon-cache in uninstall-hook
Status: RESOLVED FIXED
Product: gucharmap
Classification: Core
Component: general
1.10.x
Other All
: Normal normal
: ---
Assigned To: gucharmap maintainers
gucharmap maintainers
Depends on:
Blocks: 362604
 
 
Reported: 2007-04-26 20:14 UTC by David Farning
Modified: 2007-05-07 18:11 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
patch to run gtk-update-icon-cache in uninstall-hook (1.10 KB, patch)
2007-04-26 20:17 UTC, David Farning 		committed Details | Review

Description David Farning 2007-04-26 20:14:14 UTC 
Please describe the problem:
In the theme-friendly-icons gnome goal:

  http://live.gnome.org/GnomeGoals/AppIcon

We made all apps run gtk-update-icon-cache in install-hook.  They also should
call it in uninstall-hook. Refer to #362604.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 David Farning 2007-04-26 20:17:04 UTC 
Created attachment 87094 [details] [review]
patch to run gtk-update-icon-cache in uninstall-hook
Comment 2 David Farning 2007-04-26 20:43:49 UTC 
Comment on attachment 87094 [details] [review]
patch to run gtk-update-icon-cache in uninstall-hook

>Index: pixmaps/Makefile.am
>===================================================================
>--- pixmaps/Makefile.am	(revision 1331)
>+++ pixmaps/Makefile.am	(working copy)
>@@ -23,12 +23,14 @@
> 
> gtk_update_icon_cache = gtk-update-icon-cache -f -t $(datadir)/icons/hicolor
> 
>-install-data-hook:
>+install-data-hook: update-icon-cache
>+uninstall-hook: update-icon-cache
>+update-icon-cache:
> 	@-if test -z "$(DESTDIR)"; then \
> 		echo "Updating Gtk icon cache."; \
> 		$(gtk_update_icon_cache); \
> 	else \
>-		echo "*** Icon cache not updated.  After install, run this:"; \
>+		echo "*** Icon cache not updated.  After (un)install, run this:"; \
> 		echo "***   $(gtk_update_icon_cache)"; \
> 	fi
> 
>Index: ChangeLog
>===================================================================
>--- ChangeLog	(revision 1331)
>+++ ChangeLog	(working copy)
>@@ -1,3 +1,8 @@
>+2007-04-26  David Farning  <dfarning@gmail.com>
>+
>+	* pixmaps/Makefile.am (update-icon-cache): fix gtk-update-icon-cache for
>+	uninstall-hook.
>+
> 2007-04-26  Christian Persch  <chpe@gnome.org>
> 
> 	* gucharmap/gucharmap-search-dialog.c:(gucharmap_search_dialog_finalize):
Comment 3 Behdad Esfahbod 2007-04-26 21:34:41 UTC 
2007-04-26  David Farning  <dfarning@gmail.com>

        * pixmaps/Makefile.am (update-icon-cache): fix gtk-update-icon-cache for
        for uninstall-hook.