Bug 433521 – Pressing <ctrl> + a can crash sudoku

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 433521 - Pressing <ctrl> + a can crash sudoku


Summary:	Pressing <ctrl> + a can crash sudoku


Status:	RESOLVED FIXED

Product:	gnome-games-superseded
Classification:	Deprecated
Component:	gnome-sudoku
Version:	2.26.x
Hardware:	Other All

Importance:	High critical
Target Milestone:	---
Assigned To:	GNOME Games maintainers
QA Contact:	GNOME Games maintainers

URL:
Whiteboard:

Duplicates:	466228 515669 517138 524395 527019 530681 533575 539620 539798 546282 552524 552995 556436 558329 562092 579567 fill_crash (view as bug list)
Depends on:
Blocks:

Reported:	2007-04-26 07:36 UTC by s120120
Modified:	2010-04-09 21:03 UTC

See Also:
GNOME target:	---
GNOME version:	2.25/2.26

Attachments
race condition fix? (851 bytes, patch) 2010-01-26 23:39 UTC, ultramancool	committed	Details \| Review

Description s120120 2007-04-26 07:36:13 UTC

What were you doing when the application crashed?
rellenando todos los cuadrados


Distribution: Ubuntu 7.04 (feisty)
Gnome Release: 2.18.1 2007-04-11 (Ubuntu)
BugBuddy Version: 2.18.1

System: Linux 2.6.20-15-generic #2 SMP Sun Apr 15 06:17:24 UTC 2007 x86_64
X Vendor: The X.Org Foundation
X Vendor Release: 70200000
Selinux: No
Accessibility: Disabled
GTK+ Theme: Human
Icon Theme: Human

Memory status: size: 0 vsize: 0 resident: 0 share: 0 rss: 0 rss_rlim: 0
CPU usage: start_time: 0 rtime: 0 utime: 0 stime: 0 cutime:0 cstime: 0 timeout: 0 it_real_value: 0 frequency: 0



----------- .xsession-errors ---------------------
    self.autofiller.perform()

+ Trace 130638

File "/usr/lib/python2.5/site-packages/gnome_sudoku/gtk_goodies/Undo.py", line 43 in perform
```
self.action(*self.action_args)
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/gnome_sudoku.py", line 661 in <lambda>
```
lambda *args: self.autofilled.append(self.gsd.auto_fill()),
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/gsudoku.py", line 1166 in auto_fill
```
self.add_value(coords[0],coords[1],val)
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/gsudoku.py", line 1109 in add_value
```
self.grid.add(x,y,val,True)
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/sudoku.py", line 549 in add
```
SudokuGrid.add(self,x,y,val,*args,**kwargs)
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/sudoku.py", line 126 in add
```
raise ConflictError(TYPE_COLUMN,(x,y),val)
```

ConflictError: (1, (8, 8), 9)

--------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/gnome_sudoku/gnome_sudoku.py", line 665, in auto_fill_cb
    self.autofiller.perform()

+ Trace 130638

File "/usr/lib/python2.5/site-packages/gnome_sudoku/gtk_goodies/Undo.py", line 43 in perform
```
self.action(*self.action_args)
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/gnome_sudoku.py", line 661 in <lambda>
```
lambda *args: self.autofilled.append(self.gsd.auto_fill()),
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/gsudoku.py", line 1166 in auto_fill
```
self.add_value(coords[0],coords[1],val)
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/gsudoku.py", line 1109 in add_value
```
self.grid.add(x,y,val,True)
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/sudoku.py", line 549 in add
```
SudokuGrid.add(self,x,y,val,*args,**kwargs)
```
File "/usr/lib/python2.5/site-packages/gnome_sudoku/sudoku.py", line 126 in add
```
raise ConflictError(TYPE_COLUMN,(x,y),val)
```

ConflictError: (1, (8, 8), 9)

Comment 1 Robert Ancell 2007-04-27 00:50:23 UTC

Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.


*** This bug has been marked as a duplicate of 430463 ***

Comment 2 Robert Ancell 2007-05-18 13:52:34 UTC


*** This bug has been marked as a duplicate of 430893 ***

Comment 3 Thomas Andersen 2008-08-07 23:18:13 UTC

Jason Clinton wrote in another bug:

I think this is a race condition. The callback is running twice over the top of
itself. (Press CTRL-A twice quickly.) Use a mutex to lock the CTRL-A callback
while it is running to keep it from running dups at the same time.

Comment 4 Thomas Andersen 2008-08-07 23:29:30 UTC

*** Bug 466228 has been marked as a duplicate of this bug. ***

Comment 5 Thomas Andersen 2008-08-07 23:39:34 UTC

*** Bug 515669 has been marked as a duplicate of this bug. ***

Comment 6 Thomas Andersen 2008-08-07 23:48:22 UTC

*** Bug 517138 has been marked as a duplicate of this bug. ***

Comment 7 Thomas Andersen 2008-08-07 23:48:37 UTC

*** Bug 524395 has been marked as a duplicate of this bug. ***

Comment 8 Thomas Andersen 2008-08-07 23:48:55 UTC

*** Bug 527019 has been marked as a duplicate of this bug. ***

Comment 9 Thomas Andersen 2008-08-07 23:50:13 UTC

*** Bug 530681 has been marked as a duplicate of this bug. ***

Comment 10 Thomas Andersen 2008-08-07 23:50:32 UTC

*** Bug 533575 has been marked as a duplicate of this bug. ***

Comment 11 Thomas Andersen 2008-08-07 23:51:03 UTC

*** Bug 539620 has been marked as a duplicate of this bug. ***

Comment 12 Thomas Andersen 2008-08-07 23:51:18 UTC

*** Bug 539798 has been marked as a duplicate of this bug. ***

Comment 13 Thomas Andersen 2008-08-07 23:51:41 UTC

*** Bug 546282 has been marked as a duplicate of this bug. ***

Comment 14 Gianluca Borello 2008-09-20 12:17:42 UTC

*** Bug 552995 has been marked as a duplicate of this bug. ***

Comment 15 Gianluca Borello 2008-10-29 13:08:57 UTC

*** Bug 558329 has been marked as a duplicate of this bug. ***

Comment 16 Jesse Zhang 2008-11-04 13:19:28 UTC

*** Bug 556436 has been marked as a duplicate of this bug. ***

Comment 17 Robert Ancell 2008-11-05 05:51:46 UTC

*** Bug 552524 has been marked as a duplicate of this bug. ***

Comment 18 Jesse Zhang 2008-11-24 13:37:22 UTC

*** Bug 562092 has been marked as a duplicate of this bug. ***

Comment 19 Fabio Durán Verdugo 2009-04-20 02:40:28 UTC

*** Bug 579567 has been marked as a duplicate of this bug. ***

Comment 20 Akhil Laddha 2010-01-20 10:30:03 UTC

*** Bug 607536 has been marked as a duplicate of this bug. ***

Comment 21 ultramancool 2010-01-26 23:39:23 UTC

Created attachment 152365 [details] [review]
race condition fix?

If this is a race condition with multiple solvers running at the same time as Thomas Andersen had suggested then this should block it.

Comment 22 Thomas Andersen 2010-04-06 19:22:41 UTC

Comment on attachment 152365 [details] [review]
race condition fix?

Thanks. Could you provide a patch created with git format-patch?

Or a name so I can give you credit as the author.

Comment 23 Thomas Andersen 2010-04-09 21:03:29 UTC

Comment on attachment 152365 [details] [review]
race condition fix?

Oh well, I committed it with a reference to just your email:
http://git.gnome.org/browse/gnome-games/commit/?id=212f40519e29d7afad05cd307980acfd2b355e60

Thanks ultramancool! :)