After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 431635 - Better show http://<vnc_server>:<port> when enable http_server in vino-preferences.
Better show http://<vnc_server>:<port> when enable http_server in vino-prefer...
Status: RESOLVED FIXED
Product: vino
Classification: Applications
Component: Preferences Dialog
2.18.x
Other All
: Normal normal
: ---
Assigned To: Vino Maintainer(s)
Vino Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-04-20 10:55 UTC by Halton Huo
Modified: 2007-06-30 21:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
patch for 431635 (6.63 KB, patch)
2007-04-20 14:49 UTC, Halton Huo 		none Details | Review
new patch for bug #431635 (6.74 KB, patch)
2007-05-01 11:34 UTC, Halton Huo 		none Details | Review
new patch for bug #431635 (6.83 KB, patch)
2007-05-01 11:59 UTC, Halton Huo 		committed Details | Review

Description Halton Huo 2007-04-20 10:55:30 UTC 
Please describe the problem:
vncviewer is not installed by default in some systems, such as solaris and windows. So it is better show and send email as http://<vnc_server>:<port> when --enable-http-server on server. This may be a feature request. 

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Mark McLoughlin 2007-04-20 12:21:02 UTC 
Yep, it'd be fine to show this if, and only if, vino is built with --enable-http-server
Comment 2 Halton Huo 2007-04-20 14:49:07 UTC 
Created attachment 86701 [details] [review]
patch for 431635

please review.
Comment 3 Halton Huo 2007-05-01 11:34:19 UTC 
Created attachment 87319 [details] [review]
new patch for bug #431635

Little change on previous patch: Fix http port mistake

When 5800 is used, will get 5799, not 5801, there is logic error in function start_probing_at().

start_probing_at (int rfb_port)
{
  if (rfb_port >= VINO_RFB_MIN_PORT && rfb_port <= VINO_RFB_MAX_PORT)
-    return VINO_HTTP_MIN_PORT + (VINO_RFB_MIN_PORT - rfb_port);
+    return VINO_HTTP_MIN_PORT + (rfb_port - VINO_RFB_MIN_PORT);

  return VINO_HTTP_MIN_PORT;
}
Comment 4 Halton Huo 2007-05-01 11:59:46 UTC 
Created attachment 87325 [details] [review]
new patch for bug #431635

change on previous patch:
by default display http://server:5800 not http://server:0
Comment 5 Jonh Wendell 2007-06-30 18:49:56 UTC 
It's fine to me. Mark?
Comment 6 Mark McLoughlin 2007-06-30 21:13:23 UTC 
Yep, looks fine
Comment 7 Jonh Wendell 2007-06-30 21:51:18 UTC 
2007-06-30  Jonh Wendell <jwendell@gnome.org>

	* capplet/Makefile.am,
	  capplet/vino-preferences.c,
	  server/vino-http.[hc],
	  server/vino-dbus-listener.c: Show http server address in vino-preferences
	  if vino is compiled with http support.
	  Patch from Halton Huo, closes #431635.