GNOME Bugzilla – Bug 423382
Invalid UTF-8 in errors coming from gnupg
Last modified: 2007-04-19 22:55:43 UTC
When using PGP encryption, if we are in a non UTF-8 locale, error dialogs are empty because of invalid UTF-8.
Created attachment 85393 [details] [review] Convert messages to UTF-8
patch looks good except it'd be better if it followed the coding guidelines... - don't use gchar, use char - don't use {}'s for 1-statement if/else's - char *var, not char* var - space before '(' of param lists fix those issues and write up a ChangeLog entry and I'd say this patch was golden :)
actually... why are you converting the diagnostics? they should already be in utf-8.
I first wrote the patch only on status because I get empty dialog when an error occur (with an invalid error UTF8 in the console). For the diagnostics I added this part to the patch as I could not find that they were in UTF-8 so I thought they had the same issue, I'll have an other look.
Created attachment 86016 [details] [review] Convert messages to UTF-8 OK, I removed the part about diagnostics and used char * instead of gchar*
looks good, thanks
Updating bug status as per comment #6
Commited