After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 421715 - do not allow sourcefactories buttons to be squashed
do not allow sourcefactories buttons to be squashed
Status: RESOLVED OBSOLETE
Product: pitivi
Classification: Other
Component: User interface
Git
Other All
: Normal normal
: Git
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks: 337894
 
 
Reported: 2007-03-23 00:20 UTC by Jean-François Fortin Tam
Modified: 2007-04-25 05:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch that removes the size request (3.33 KB, patch)
2007-03-23 00:20 UTC, Jean-François Fortin Tam 		none Details | Review
screenshot before the patch (33.59 KB, image/png)
2007-03-23 00:21 UTC, Jean-François Fortin Tam 		  Details
screenshot after the patch (33.51 KB, image/png)
2007-03-23 00:21 UTC, Jean-François Fortin Tam 		  Details

Description Jean-François Fortin Tam 2007-03-23 00:20:17 UTC 
I will attach a patch that fixes the bug in the media library notebook: when using the French version (with slightly longer translated strings), the buttons were "overflowing" from the gtk notebook onto the rest of the UI, which was plain ugly.

Found out the problem was due to this:
self.set_size_request(300, -1)

The size request messes up the layout and is, I think, unecessary since the buttons ensure that the layout has a suitable minimum size.

This patch is made against my already-patched trunk copy (see bug #415060). The actual change of this patch is just one removed line (line 12 in the .patch file).
Comment 1 Jean-François Fortin Tam 2007-03-23 00:20:44 UTC 
Created attachment 85147 [details] [review]
patch that removes the size request
Comment 2 Jean-François Fortin Tam 2007-03-23 00:21:00 UTC 
Created attachment 85148 [details]
screenshot before the patch
Comment 3 Jean-François Fortin Tam 2007-03-23 00:21:19 UTC 
Created attachment 85149 [details]
screenshot after the patch
Comment 4 Jean-François Fortin Tam 2007-04-25 02:25:16 UTC 
Edward, I think you actually incorporated that patch in current SVN, am I right? Can't find traces of size requests for the source factories now...
Comment 5 Edward Hervey 2007-04-25 05:57:24 UTC 
it seems I fixed the issue... without using your patch :( I'm still not very pleased about the general resizing behaviour currently. When the source list switches from the explanation message to the actual list, it sometimes changes size... annoying.

I'm going to close this bug. I'll have to be more careful next time.