After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 420578 - [subparse] add more colour map in sami parser
[subparse] add more colour map in sami parser
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 0.10.13
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-20 15:38 UTC by Young-Ho Cha
Modified: 2007-03-21 10:27 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
add more html colour map in sami parser (1.77 KB, patch)
2007-03-20 15:39 UTC, Young-Ho Cha 		committed Details | Review

Description Young-Ho Cha 2007-03-20 15:38:13 UTC 
Please describe the problem:
As described http://bugzilla.gnome.org/show_bug.cgi?id=169936#c28 , some html colour names are not supported by pango, and applied workaround about silver colour only.

There is html color name page (http://www.w3schools.com/html/html_colornames.asp) and I found only 8 colour name are not supported.

I'll attach a patch to support these colors. Please apply it.

Thank you.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Young-Ho Cha 2007-03-20 15:39:04 UTC 
Created attachment 84980 [details] [review]
add more html colour map in sami parser
Comment 2 Tim-Philipp Müller 2007-03-21 10:27:01 UTC 
Committed, thanks:

 2007-03-21  Tim-Philipp Müller  <tim at centricular dot net>

       Patch by: Young-Ho Cha <ganadist at chollian net>

       * gst/subparse/samiparse.c: (handle_start_font):
         Special-case some more colour names that pango doesn't handle by
         default. Fixes #420578.