After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 419578 - TIFF page attributes not being kept
TIFF page attributes not being kept
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: Plugins
git master
Other All
: Normal minor
: ---
Assigned To: GIMP Bugs
GIMP Bugs
: 335615 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-03-18 01:04 UTC by Pedro Venda
Modified: 2018-05-24 12:09 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Pedro Venda 2007-03-18 01:04:03 UTC
the 'nona' tool stiches different picture files together to form a panorama. one of its output formats is multiple splits to have the stitching optimized by by the 'enblend' tool. 
these split images have a page attribute that serves as an offset to place each of them between the other splits that compose the panorama. as an example to illustrate this, one of my panoramas has its split 01 with an offset of +0+0 and split 02 with an offset of +518+35.

when editing and saving any of the above mentioned splits, gimp silently discards that offset information. 

example image before editing:
pjlv@archon ~/panorama-01 $ identify test-03-split0004.tif
test-03-split0004.tif TIFF 1658x2385 1658x2385+2212+138 DirectClass 8-bit 6.90316mb 0.670u 0:02

example image after editing:
pjlv@archon ~/panorama-01 $ identify test-03-split0004_.tif
test-03-split0004_.tif TIFF 1658x2385 1658x2385+0+0 DirectClass 8-bit 4.362mb 0.500u 0:02

If this is a feature, I think the user should be warned that the page attribute will be lost.
Comment 1 Sven Neumann 2007-03-18 11:40:30 UTC
This could be fixed in the TIFF plug-in by attaching the page attributes as a parasite and saving them if the parasite exists. I doubt that anyone will feel motivated enough to do this change, but if you need this feature, feel free to code it and to attach your patch here.
Comment 2 Mukund Sivaraman 2007-04-26 11:02:49 UTC
Fix implemented in changeset 22340.

2007-04-26  Mukund Sivaraman  <muks@mukund.org>

        * plug-ins/common/tiff-save.c: save the layer offsets too, to
        fix bug #419578.

The tiff-load plug-in already loads and uses these page offsets.

Comment 3 Mukund Sivaraman 2007-04-26 12:29:37 UTC
Fix disabled in changeset 22344. This can be looked at in 2.6.

2007-04-26  Mukund Sivaraman  <muks@mukund.org>

        * plug-ins/common/tiff-save.c: disabled the layer offsets saving
        code. This can be re-enabled in 2.6, when the load plug-in is
        patched to support these saved offsets.

        * plug-ins/common/tiff-load.c: marked the code for the above
        with a TODO comment.

Comment 4 Sven Neumann 2008-01-15 13:58:07 UTC
Changing version to "Current SVN" as this request is not specific to any
particular version.
Comment 5 Rihards 2008-07-11 13:03:21 UTC
this seems to be a dupe of bug 335615
Comment 6 Michael Natterer 2013-10-27 22:25:47 UTC
*** Bug 335615 has been marked as a duplicate of this bug. ***
Comment 7 Michael Natterer 2013-10-27 22:26:50 UTC
Mukund, is this fixed in the meantime?
Comment 8 Mukund Sivaraman 2014-05-17 00:32:26 UTC
I don't remember what the problem was here.

The file-tiff-load plug-in has code to read offsets and apply them when loading. There is no interactive dialog asking questions.

The file-tiff-save plug-in got code to write layer offsets but it was disabled because the file-tiff-load plug-in didn't have the question dialog (whether to apply layer offsets or not).

Because offsets are applied anyway currently, I don't know why we bother to not write them back.
Comment 9 GNOME Infrastructure Team 2018-05-24 12:09:15 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/235.