After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 419535 - use gi18n[-lib].h instead of bonobo-i18n.h
use gi18n[-lib].h instead of bonobo-i18n.h
Status: RESOLVED FIXED
Product: bonobo
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Michael Meeks
bonobo qa
Depends on:
Blocks:
 
 
Reported: 2007-03-17 22:42 UTC by Christian Persch
Modified: 2007-03-23 18:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for libbonobo (16.56 KB, patch)
2007-03-17 22:43 UTC, Christian Persch 		committed Details | Review
patch for libbonoboui (11.69 KB, patch)
2007-03-17 22:47 UTC, Christian Persch 		committed Details | Review

Description Christian Persch 2007-03-17 22:42:17 UTC 
bonobo-i18n.h is going to be deprecated (bug 419533) and is problematic (bug 363033). We should remove its use whereever possible; I'm going to attach patches for libbonobo and libbonoboui to use glib's i18n headers internally instead of bonobo-i18n.h. Ok to commit them?
Comment 1 Christian Persch 2007-03-17 22:43:33 UTC 
Created attachment 84797 [details] [review]
patch for libbonobo

Note that it's ok to remove bonobo-activation-i18n.h since it's a non-public header.
This patch uses gi18n.h or gi18n-lib.h, depending on whether the file is used standalone (activation server) or in the bonbo library.
Comment 2 Christian Persch 2007-03-17 22:47:31 UTC 
Created attachment 84798 [details] [review]
patch for libbonoboui

Note that someone had already converted some of the libbonobo files to gi18n.h, but did so wrongly, since it needs gi18n-lib.h there. This patch corrects that.
Comment 3 Kjartan Maraas 2007-03-23 14:44:53 UTC 
Please commit. If you're sure it doesn't introduce any problems it can go in on gnome-2-18 as well.
Comment 4 Christian Persch 2007-03-23 18:51:45 UTC 
Committed.

While I don't think there'll be any problems, it's fine to just leave it on trunk.