After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 419051 - Kill MailSession's interactive flag?
Kill MailSession's interactive flag?
Status: RESOLVED WONTFIX
Product: evolution
Classification: Applications
Component: Mailer
2.10.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-03-16 18:04 UTC by Matthew Barnes
Modified: 2008-01-24 23:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (3.08 KB, patch)
2007-03-16 18:05 UTC, Matthew Barnes
reviewed Details | Review

Description Matthew Barnes 2007-03-16 18:04:26 UTC
I propose killing MailSession's "interactive" flag, along with the corresponding get/set functions?  The flag no longer seems to serve a purpose.  In the current code base, it's always TRUE.

Based on CVS history and mail/ChangeLog.pre-1-4, it looks like the code dates back to 2000, and its original purpose was to delay asking the user for a password until after the start-up splash screen disappeared.

Here's the oldest relevant ChangeLog entry that I could find:

2000-12-11  Dan Winship  <danw@helixcode.com>

        * session.c (mail_session_enable_interaction): New function to
        tell the code that it's ok (or not) to interact with the user
        when trying to authenticate to a service. Starts out turned off.
        (mail_session_request_dialog): If interaction is disabled, fail
        if the password isn't in the cache.

        * component-factory.c (owner_set_cb): Call
        mail_session_enable_interaction() after everything else. (This
        means that the IMAP password dialog will no longer pop up [under
        the splash screen] at startup.)
Comment 1 Matthew Barnes 2007-03-16 18:05:48 UTC
Created attachment 84732 [details] [review]
Proposed patch
Comment 2 Srinivasa Ragavan 2007-03-18 18:23:58 UTC
Ah!! Atlast I found a way to kill the similiar issue with the exchange password dialog. I think we should use this to avoid the exchange password dialog that comes even before the shell comes out. 

Matthew, I dont feel, we should kill this. It could be more useful in some other scenarios too. 
Comment 3 Matthew Barnes 2007-03-18 21:50:58 UTC
Hmm, I guess I'll have to un-deprecate e_passwords_cancel() in bug #376991 then.
That's too bad; it'll complicate the design a bit.
Comment 4 Matthew Barnes 2008-01-24 23:39:05 UTC
Closing as WONTFIX.  Seems like an "interactive" state should really be managed from the Shell.  Perhaps we'll revisit this in the future.