After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 417538 - unapproved change broke theme management
unapproved change broke theme management
Status: RESOLVED FIXED
Product: gnome-screensaver
Classification: Deprecated
Component: daemon
CVS HEAD
Other Linux
: Normal critical
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-12 17:23 UTC by William Jon McCann
Modified: 2007-03-13 22:43 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description William Jon McCann 2007-03-12 17:23:17 UTC
This change:
http://svn.gnome.org/viewcvs/gnome-screensaver?view=rev&revision=1132

Broke the theme management because it changed the name of the Screensaver category.   We use a menu to find desktop files with this category:
http://svn.gnome.org/viewcvs/gnome-screensaver/trunk/data/gnome-screensavers.menu.in?revision=665&view=markup

I've sent an email to the release team about this:
http://mail.gnome.org/archives/release-team/2007-March/msg00111.html
Comment 1 William Jon McCann 2007-03-12 17:26:47 UTC
Also see:
http://standards.freedesktop.org/menu-spec/latest/apa.html

"Screensaver" is the correct category.

Comment 2 William Jon McCann 2007-03-12 18:17:00 UTC
2007-03-12  William Jon McCann  <mccann@jhu.edu>

	* savers/popsquares.desktop.in (Categories):
	* savers/personal-slideshow.desktop.in (Categories):
	Revert the unapproved and incorrect changes.
	Fixes #417538
Comment 3 Christian Kirbach 2007-03-12 21:54:37 UTC
I am sorry for causing this

nazgul@dragonscale:/cvs/gnome/gnome-screensaver$ for i in `find . -name '*.desktop' `; do desktop-file-validate $i; done
./savers/cosmos-slideshow.desktop: error: Categories values are case sensitive (should be "ScreenSaver" instead of "Screensaver")
./savers/personal-slideshow.desktop: error: Categories values are case sensitive (should be "ScreenSaver" instead of "Screensaver")
./savers/footlogo-floaters.desktop: error: Categories values are case sensitive (should be "ScreenSaver" instead of "Screensaver")
./savers/popsquares.desktop: error: Categories values are case sensitive (should be "ScreenSaver" instead of "Screensaver")
Comment 4 William Jon McCann 2007-03-12 22:04:23 UTC
No hard feelings - I know you only meant to help.

Hmm, I'm glad you mention that it doesn't validate.  Can you open a new bug for this so we can get to the bottom of it?  Thanks.
Comment 5 Christian Kirbach 2007-03-13 22:33:29 UTC
actually, this must be a bug of desktop-file-validate *or* its database of known keywords is not up-to-date. I run Ubuntu Edgy 6.10 .


> should be "ScreenSaver" instead of "Screensaver

this is what lured me into capitalising by the way.
Comment 6 Christian Kirbach 2007-03-13 22:43:28 UTC
indeed, the version was too old. It now validates correctly. The .desktop files are fine.

Blame seb128 :)