After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 417350 - GNOME Goal #3: Remove "Application" category from .desktop files
GNOME Goal #3: Remove "Application" category from .desktop files
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-12 05:45 UTC by Pepito Seg
Modified: 2007-03-22 12:19 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Pepito Seg 2007-03-12 05:45:04 UTC
Please describe the problem:
gui/gdmphotosetup.desktop.in  remove "Application" and add "GTK"
gui/gdmflexiserver-xnest.desktop.in remove "Application" and add "GNOME" "GTK"



Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Pepito Seg 2007-03-12 06:32:52 UTC
In file gdmphotosetup.desktop.in add GNOME too
Comment 2 Brian Cameron 2007-03-12 08:18:49 UTC
Thanks.  I fixed this in CVS head so it will work properly in GNOME 2.18.
Comment 3 Jonh Wendell 2007-03-14 12:51:39 UTC
Hi.

Is there any reason to remove 'System' from Categories? By leaving only 'Settings' on that field in gdmsetup.desktop, for example, makes it appear under Preferences menu, not in Administration.
Comment 4 Brian Cameron 2007-03-15 07:48:43 UTC
This makes sense to me, since gdmsetup is for changing your login setup preferences.  It's a configuration program, not really a system tool.

In GNOME 2.18, most distros are moving gdmsetup into "System->Control Center".
This is why the label just says "Login" rather than "Login Preferences" since it is implied that it belongs in preferences by its location.  None of the other choices in control center say "Preferences" in their title.

However, if you think it should belong in System in some situations (e.g. perhaps older versions of GNOME it makes more sense to put it there), then we can talk about making it configurable where the menu choice gets placed.  And I'm happy to debate where it should be placed if you think it belongs somewhere different.
Comment 5 Jonh Wendell 2007-03-15 11:39:37 UTC
Hi Brian.

Ubuntu, for example, doesn't ship new control center by default.

I think all items under Preferences menu should change user preferences of logged user. gdmsetup changes preferences for all users (or: system), not only the logged user.

What do you think?
Comment 6 Brian Cameron 2007-03-15 12:39:21 UTC
This is a hard question - since different distros ship things differently, I don't know how we can please everyone.

Perhaps we need to make it configurable so distros who want a non-default location can specify such when they call configure (or identify the distros in the configure script and set the values to the right default location for the distro?)

Maybe it would be good to get the usability team involved and ask them what the right default for GDM here is.

I'm not sure distros that do not ship control-center are the right default settings for GDM, though.  Isn't the new control center the right approach long term?
Comment 7 Ray Strode [halfline] 2007-03-15 17:43:04 UTC
Note the control-center shell got pulled before gnome 2.18 and I think most distros aren't using it yet.
Comment 8 Brian Cameron 2007-03-16 11:38:57 UTC
I'd be happy to update the desktop files to have the right category if someone can give me an offical perspective of what they should be.
Comment 9 Sebastien Bacher 2007-03-19 21:04:12 UTC
GNOME 2.18 doesn't use the new shell so the categorization should be decided for the menus usecase. The change moves the item to the preferences, we consider the administration menu being the right location because gdmsetup can be used by the administrator only
Comment 10 Brian Cameron 2007-03-21 10:48:47 UTC
Could you specify how the field should be changed so it works best with 2.18?
I've messed this up already once, so I'd appreciate if someone could share with me exactly how this should look.
Comment 11 Jonh Wendell 2007-03-21 10:54:09 UTC
Categories=GNOME;GTK;Settings;System;

??
Comment 12 Brian Cameron 2007-03-21 14:16:27 UTC
When I change gdmphotosetup.desktop to this category, I don't see it anywhere in the Solaris menus.  The "All Applications->System Tools" menu doesn't have "Login Photo" nor is there a System sub-menu.  Likewise I don't see anything under "Preferences".

Is this because there is a bug with the Solaris menus?  Are you sure that's the right category for default use?
Comment 13 Brian Cameron 2007-03-21 14:17:01 UTC
When I change gdmphotosetup.desktop to this category, I don't see it anywhere in the Solaris menus.  The "All Applications->System Tools" menu doesn't have "Login Photo" nor is there a System sub-menu.  Likewise I don't see anything under "Preferences".

Is this because there is a bug with the Solaris menus?  Are you sure that's the right category for default use?
Comment 14 Brian Cameron 2007-03-21 14:28:01 UTC
Oh sorry - this does seem to fix it.  It is in "Administration" menu.  

Okay.  I will commit this patch to 2.16 and HEAD.  Can you verify it is now okay?
Comment 15 Jonh Wendell 2007-03-21 14:33:05 UTC
btw, i was talking about gdmsetup utility.

You meant 2.18, right?
Comment 16 Brian Cameron 2007-03-21 14:53:57 UTC
Yes, I meant 2.18.  It is now in 2.18 and head.  The code in 2.16 is unchanged.

I updated the Category for both gdmphotosetup and gdmsetup, which are both configuration programs so I assume they should go in the same place.  Note
most distros don't ship gdmphotosetup or mark gdmphotosetup as NoDisplay or whatnot so it normally doesn't show up (since About Me capplet is considered better).

Does this make sense?  If so, and you like the code in 2.18 and head, then please close this bug.
Comment 17 Jonh Wendell 2007-03-21 15:05:14 UTC
OK, agree with you, most distros ship gdmphotosetup hidden by default, but it does not belong to System category, just Settings. It does not need root privileges to run, it changes user preferences, not system/global preferences.
Comment 18 Brian Cameron 2007-03-22 06:37:46 UTC
*sigh*

At least gdmsetup seems to be okay.

Could you tell me exactly what line should be in gdmphotosetup for Categories, and I'll update it in 2.18 and HEAD.  Thanks.
Comment 19 Jonh Wendell 2007-03-22 11:07:40 UTC
Categories=GNOME;GTK;Settings;
Comment 20 Brian Cameron 2007-03-22 12:19:39 UTC
Thank you!  I updated in 2.18 and SVN head.   So I think this is now fixed.  I'm closing the bug - please reopen if there are any further issues.