After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 415807 - Help in seahorse-preferences doesn't display
Help in seahorse-preferences doesn't display
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: 1.0.0
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2007-03-07 19:15 UTC by Vincent Untz
Modified: 2007-05-04 17:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixes dialog attachment (1.08 KB, patch)
2007-03-07 20:42 UTC, Adam Schreiber
committed Details | Review
Fixes the display issue (741 bytes, patch)
2007-05-04 17:48 UTC, Adam Schreiber
committed Details | Review

Description Vincent Untz 2007-03-07 19:15:08 UTC
In encryption preferences, when I click on help, it doesn't work (ubuntu probably doesn't install the files). The error dialog has this string:

Impossible d'afficher l'aide : Unable to find help paths /usr/share/gnome/help/seahorse-preferences or /usr/share/gnome/help/seahorse-preferences.Please check your installation

Note that there's a missing space before "Please" and no dot at the end.

Also, this dialog has no window icon.
Comment 1 Adam Schreiber 2007-03-07 20:41:28 UTC
Confirmed.  I receive a similar message.

Could not display help: Unable to find the help files in either /usr/share/gnome/help/seahorse-preferences or /usr/share/gnome/help/seahorse-preferences.  Please check your installation

Note that there is a space in front of Please and no period at the end of the line.  This message is generated from an GError returned from gnome_help_display. Only the "Could not display help portion of the message comes from seahorse.

The real bug is somehow wrapped up in that to get bug buddy to work properly, "seahorse-preferences" is passed into gnome_program_init instead of PACKAGE.  This results in documentation not being found.

I'll attach a patch that has a minor string change and fixes the dialog not being attached to the parent window.  I'm not sure how to fix the gnome_program_init bit without sacrificing bug buddy operation.
Comment 2 Adam Schreiber 2007-03-07 20:42:02 UTC
Created attachment 84193 [details] [review]
Fixes dialog attachment
Comment 3 Stef Walter 2007-03-17 20:06:42 UTC
Not sure how to fix the help file problem, but will look into it.

The patch seems unrelated to the problem, but second half of it can be committed to the gnome-2-18 branch. That branch is however still in string freeze so the first half of the patch will have to wait. 

Comment 4 Adam Schreiber 2007-03-17 22:52:35 UTC
Committed.

2007-03-17  Adam Schreiber  <sadam@clemson.edu>

    * libseahorse/seahorse-widget.c: Link swidget error dialogs to their 
    parent
Comment 5 Sebastian Dröge (slomo) 2007-05-01 23:37:13 UTC
Is there any progress on this?
Comment 6 Adam Schreiber 2007-05-04 17:47:29 UTC
I found the answer by digging deep in libgnome.  It required changing which help helper seahorse-widget.c invokes, but it appears to work.  I'll attach the patch so that downstreamers can patch stable if they so desire.

2007-05-04  Adam Schreiber  <sadam@clemson.edu>

    * libseahorse/seahorse-widget.c: Change gnome_help_display function 
    called.  Fixes bug #415807

Committed revision 1755.
Comment 7 Adam Schreiber 2007-05-04 17:48:07 UTC
Created attachment 87556 [details] [review]
Fixes the display issue