After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 415353 - Volume Control displays separator before first playback control
Volume Control displays separator before first playback control
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: gnome-volume-control
unspecified
Other Linux
: Normal minor
: ---
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-06 15:28 UTC by Loïc Minier
Modified: 2008-03-18 11:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix (Matt Kraai) (415 bytes, patch)
2007-03-06 15:30 UTC, Loïc Minier 		committed Details | Review

Description Loïc Minier 2007-03-06 15:28:43 UTC 
Hi,

Matt Krai reported in Debian bug http://bugs.debian.org/413678:
"""
Volume Control displays a separator at the left of the Playback tab if
the first Playback control shown is not the first Playback control
possibly shown.  The attached patch fixes this problem by not showing
this separator unless a previous control has been visible.
"""

I'll attach his patch re-applied against SVN trunk.

Bye,
Comment 1 Loïc Minier 2007-03-06 15:30:31 UTC 
Created attachment 84075 [details] [review]
Proposed fix (Matt Kraai)
Comment 2 Ronald Bultje 2007-03-06 17:35:00 UTC 
We're in freeze, I'd rather wait until the next cycle (I know this is silly, but I have little time to test and ask for a freeze request...).
Comment 3 Loïc Minier 2007-12-18 15:41:50 UTC 
I guess it can be committed now?
Comment 4 Marc-Andre Lureau 2008-03-17 23:07:21 UTC 
(In reply to comment #3)
> I guess it can be committed now?
> 

Hi loic, please commit in trunk! Thanks
Comment 5 Loïc Minier 2008-03-18 07:04:33 UTC 
Committed to trunk as r3799; do you want me to commit to gnome-2-22 as well?

2008-03-18  Loïc Minier <lool@dooz.org>

       * gst-mixer/src/element.c: Only show a separator at the left of the
       Playback control if a previous control has been visible; patch by
       Matt Krai; fixes #415353
Comment 6 Marc-Andre Lureau 2008-03-18 10:17:34 UTC 
(In reply to comment #5)
> Committed to trunk as r3799; do you want me to commit to gnome-2-22 as well?
> 

Change is safe. Yes you can. I'll have to roll my second tarball!! :)
Comment 7 Loïc Minier 2008-03-18 11:16:18 UTC 
Merged r3799 from trunk as r3800 in branches/gnome-2-22

2008-03-18  Loïc Minier <lool@dooz.org>

       * gst-mixer/src/element.c: Only show a separator at the left of the
       Playback control if a previous control has been visible; patch by
       Matt Krai; fixes #415353