After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 415060 - various toolbar HIG fixes
various toolbar HIG fixes
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other Linux
: Normal normal
: 0.10.3
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks: 337894
 
 
Reported: 2007-03-05 20:32 UTC by Jean-François Fortin Tam
Modified: 2007-04-25 09:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
suggestions screenshot (137.57 KB, image/png)
2007-03-05 20:33 UTC, Jean-François Fortin Tam
  Details
patch against revision 896 (4.84 KB, patch)
2007-03-10 18:30 UTC, Jean-François Fortin Tam
none Details | Review
cleaned patch updated for revision 938 (4.07 KB, patch)
2007-04-25 02:33 UTC, Jean-François Fortin Tam
committed Details | Review

Description Jean-François Fortin Tam 2007-03-05 20:32:56 UTC
based on SVN revision 893, here are some comments I have regarding the user interface. Sadly, I cannot fix it myself as I can only use glade and the "main" user interface seems to be hardcoded pygtk. Please let me know what you think of these suggestions I will be attaching (as a screenshot).
Comment 1 Jean-François Fortin Tam 2007-03-05 20:33:19 UTC
Created attachment 84001 [details]
suggestions screenshot
Comment 2 Jean-François Fortin Tam 2007-03-10 18:30:23 UTC
Created attachment 84353 [details] [review]
patch against revision 896

Bilboed, I have created a patch that solves most of these issues. Could you give me your thoughts on this? Contents of this patch:

- add stock icons in sourcefactories' popup menu
- add spacing between buttons in sourcefactories
- change stock icon for the "add folders" in sourcefactories
- hide some redundant buttons from the toolbar ("save as" and "import sources")
- fix the strange 5px spacing that was present in the main vbox that made toolbars look weird
- make the "fullscreen" button a toggle button
Comment 3 Jean-François Fortin Tam 2007-04-25 02:33:07 UTC
Created attachment 86973 [details] [review]
cleaned patch updated for revision 938

- add stock icons in sourcefactories' popup menu (and change "sources" to "clips")
- change stock icon for the "add folders" in sourcefactories
- use stock buttons in the sourcefactories popup menu whenever possible, otherwise include a stock image
- hide some redundant buttons from the toolbar ("save as" and "import sources"; see screenshot for the reasoning behind that)
- remove the 5px spacing in the main vbox that made the toolbar look weird
- make the "fullscreen" button a toggle button
Comment 4 Edward Hervey 2007-04-25 05:59:37 UTC
You seem to have removed/added some code that shouldn't be removed/added. Will review and commit later, the addition of images in menus is nice.
Comment 5 Edward Hervey 2007-04-25 09:07:04 UTC
The buttons in the source list are going away (see #432714), so we're keeping the toolbar items.
The Save As stays, else you don't have anyway to save the project somewhere else, or with a different name (if you want to make a copy).

The rest is fine (great !) though :)
Comment 6 Edward Hervey 2007-04-25 09:09:33 UTC
2007-04-25  Edward Hervey  <edward@fluendo.com>

	Patch by: Jeff Fortin <nekohayo@gmail.com>
	* pitivi/ui/mainwindow.py:
	Make fullscreen action toggle-able (like other gtk/gnome apps).
	Remove 5px spacing in Global VBox that made the toolbar look weird.
	* pitivi/ui/sourcefactories.py:
	Add icons to popup-menu.
	Fixes #415060