GNOME Bugzilla – Bug 415060
various toolbar HIG fixes
Last modified: 2007-04-25 09:09:33 UTC
based on SVN revision 893, here are some comments I have regarding the user interface. Sadly, I cannot fix it myself as I can only use glade and the "main" user interface seems to be hardcoded pygtk. Please let me know what you think of these suggestions I will be attaching (as a screenshot).
Created attachment 84001 [details] suggestions screenshot
Created attachment 84353 [details] [review] patch against revision 896 Bilboed, I have created a patch that solves most of these issues. Could you give me your thoughts on this? Contents of this patch: - add stock icons in sourcefactories' popup menu - add spacing between buttons in sourcefactories - change stock icon for the "add folders" in sourcefactories - hide some redundant buttons from the toolbar ("save as" and "import sources") - fix the strange 5px spacing that was present in the main vbox that made toolbars look weird - make the "fullscreen" button a toggle button
Created attachment 86973 [details] [review] cleaned patch updated for revision 938 - add stock icons in sourcefactories' popup menu (and change "sources" to "clips") - change stock icon for the "add folders" in sourcefactories - use stock buttons in the sourcefactories popup menu whenever possible, otherwise include a stock image - hide some redundant buttons from the toolbar ("save as" and "import sources"; see screenshot for the reasoning behind that) - remove the 5px spacing in the main vbox that made the toolbar look weird - make the "fullscreen" button a toggle button
You seem to have removed/added some code that shouldn't be removed/added. Will review and commit later, the addition of images in menus is nice.
The buttons in the source list are going away (see #432714), so we're keeping the toolbar items. The Save As stays, else you don't have anyway to save the project somewhere else, or with a different name (if you want to make a copy). The rest is fine (great !) though :)
2007-04-25 Edward Hervey <edward@fluendo.com> Patch by: Jeff Fortin <nekohayo@gmail.com> * pitivi/ui/mainwindow.py: Make fullscreen action toggle-able (like other gtk/gnome apps). Remove 5px spacing in Global VBox that made the toolbar look weird. * pitivi/ui/sourcefactories.py: Add icons to popup-menu. Fixes #415060