After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 414609 - art-display plugin local search misses downloaded Jamendo album covers
art-display plugin local search misses downloaded Jamendo album covers
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
0.9.8
Other All
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 437965 509507 (view as bug list)
Depends on:
Blocks: 412853
 
 
Reported: 2007-03-04 15:35 UTC by Peter
Modified: 2008-06-09 06:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.89 KB, patch)
2007-07-10 12:40 UTC, Jonathan Matthew
committed Details | Review

Description Peter 2007-03-04 15:35:42 UTC
Please describe the problem:
When downloading an entire albumn from www.jamendo.com (either via the RB plugin, or via a webbrowser) the resulting folder/directory contains:

music tracks: *.mp3 or *.ogg

text files: "License.txt" and multiple readme files in different languages, such as "[en] Readme - www.jamendo.com .txt"

cover art: "artist - album.1.jpg" (single file, high resolution)

Examples of the file name used for the cover include:

Frozen Silence - Heart of Winter.1.jpg
Celestial Aeon Project - Aeon.1.jpg
etc

Steps to reproduce:
1. Using the Jamendo plugin or your webrowser download an album from Jamendo using bit-torrent
2. Save this to a folder in your music library
3. Wait for the download to finish
3. Check that the folder contains a single image named "artist - album.1.jpg"
4. Run RB (with the art-display plugin enabled)
5. Wait for RB to import the new album
6. Play a track from the new album
7. Notice the supplied art "artist - album.1.jpg" is not found


Actual results:
See step 7

Expected results:
I would like the art display plugin to find the Jamendo supplied image

Does this happen every time?
yes

Other information:
Possible ways to fix this
(1) If the art display plugin's "local art search" finds a single image in the folder, regardless of file name, use this
(2) Extend the list of names to include "%s %s.1.jpg" % (artist, album)
(3) Enhance the Jamendo plugin to manage the download and rename the album art to something like "Cover.jpg"

Idea (1) is crude and simple, but may get an inappropriate image for some people - depends how the organise their music.  Could do this with an additional check that the filename contains the artist, album or track name?

Idea (2) may need refinement for international characters in the filename

Idea (3) is a BIG change to the Jamendo plugin, and will not "fix" the cover art for existing art.
Comment 1 Peter 2007-03-04 16:04:23 UTC
In idea (2), that should read: "%s - %s.1.jpg" % (artist, album)
Comment 2 Philip Withnall 2007-06-03 11:42:30 UTC
*** Bug 437965 has been marked as a duplicate of this bug. ***
Comment 3 Jonathan Matthew 2007-07-10 12:40:45 UTC
Created attachment 91545 [details] [review]
patch

Essentially, this is idea 2; it just looks for the artist and album name in the file name rather than using a fixed format.  There's also a longest matching prefix search, which helps find art in other some downloads.

I've tested this with a couple of not-entirely-ascii album/artist names from jamendo.  The problem is that their mp3 downloads are not correctly tagged, and the ogg downloads are not seeded terribly well.
Comment 4 Jonathan Matthew 2008-01-15 07:31:44 UTC
*** Bug 509507 has been marked as a duplicate of this bug. ***
Comment 5 Jonathan Matthew 2008-06-09 06:05:24 UTC
Committed, because .. why not?