Bug 414266 – Fails to build when srcdir != builddir

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 414266 - Fails to build when srcdir != builddir


Summary:	Fails to build when srcdir != builddir


Status:	RESOLVED FIXED

Product:	ekiga
Classification:	Applications
Component:	Build System
Version:	GIT master
Hardware:	Other All

Importance:	Immediate normal
Target Milestone:	---
Assigned To:	Snark
QA Contact:	Ekiga maintainers

URL:
Whiteboard:

Depends on:
Blocks:	414139

Reported:	2007-03-03 14:53 UTC by Loïc Minier
Modified:	2008-09-01 18:42 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Include gmconf/ via $(srcdir) (412 bytes, patch) 2007-03-03 14:54 UTC, Loïc Minier	none	Details \| Review
Include gmconf/ via $(srcdir) (take 2) (830 bytes, patch) 2007-03-03 14:59 UTC, Loïc Minier	none	Details \| Review
Fix relative include in accounts.cpp (309 bytes, patch) 2007-03-03 15:03 UTC, Loïc Minier	none	Details \| Review
Include endpoints/ via $(srcdir) (367 bytes, patch) 2007-03-03 15:06 UTC, Loïc Minier	none	Details \| Review
Fix relative config.h includes (3.59 KB, patch) 2007-03-03 15:18 UTC, Loïc Minier	none	Details \| Review
Fix a bunch of includes to be relative to srcdir (1.01 KB, patch) 2007-03-03 15:20 UTC, Loïc Minier	none	Details \| Review
Fix relative config.h includes (take 2) (8.81 KB, patch) 2007-03-03 15:33 UTC, Loïc Minier	none	Details \| Review
Fix a bunch of includes to be relative to srcdir (take 2) (8.81 KB, patch) 2007-03-03 15:35 UTC, Loïc Minier	none	Details \| Review

Description Loïc Minier 2007-03-03 14:53:26 UTC

Hi,

When building ekiga out of tree it fails with:
Making all in gmcontacts
make[4]: entrant dans le répertoire « /home/lool/jhbuild-gnome-2.18/build/ekiga/lib/gmcontacts »
/bin/sh ../../libtool --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I../.. -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gmcontacts -DG_LOG_DOMAIN=\"Ekiga\" -DSHARE_DIR=\"/home/lool/jhbuild-gnome-2.18/prefix/share/ekiga\" -I../gmconf/ -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga -pthread -DORBIT2=1 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gtk-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gtk-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/atk-1.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/cairo -I/home/lool/jhbuild-gnome-2.18/prefix/include/pango-1.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/gconf/2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/orbit-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnome-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-vfs-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gnome-vfs-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonobo-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/bonobo-activation-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnomeui-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnomecanvas-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libart-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonoboui-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-keyring-1 -I/usr/include/freetype2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libxml2 -I/usr/include/libpng12   -DORBIT2=1 -pthread -I/home/lool/jhbuild-gnome-2.18/prefix/include/evolution-data-server-1.10 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonobo-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnome-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/orbit-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/bonobo-activation-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gconf/2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-vfs-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gnome-vfs-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/libxml2   -D_REENTRANT -I/home/lool/jhbuild-gnome-2.18/prefix/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include   -DHAS_AVAHI  -I/home/lool/jhbuild-gnome-2.18/prefix/include/ptlib -I/home/lool/jhbuild-gnome-2.18/prefix/include/ptclib -I/home/lool/jhbuild-gnome-2.18/prefix/include  -I/home/lool/jhbuild-gnome-2.18/prefix/include/opal -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -DHAS_SDL  -DPTRACING -DNDEBUG -Wall -Os -g -fno-exceptions -felide-constructors -D_REENTRANT                                 -g -O2 -MT gmcontacts-remote.lo -MD -MP -MF .deps/gmcontacts-remote.Tpo -c -o gmcontacts-remote.lo /home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gmcontacts/gmcontacts-remote.cpp
 g++ -DHAVE_CONFIG_H -I. -I../.. -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gmcontacts -DG_LOG_DOMAIN=\"Ekiga\" -DSHARE_DIR=\"/home/lool/jhbuild-gnome-2.18/prefix/share/ekiga\" -I../gmconf/ -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga -pthread -DORBIT2=1 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gtk-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gtk-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/atk-1.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/cairo -I/home/lool/jhbuild-gnome-2.18/prefix/include/pango-1.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/gconf/2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/orbit-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnome-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-vfs-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gnome-vfs-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonobo-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/bonobo-activation-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnomeui-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnomecanvas-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libart-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonoboui-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-keyring-1 -I/usr/include/freetype2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libxml2 -I/usr/include/libpng12 -DORBIT2=1 -pthread -I/home/lool/jhbuild-gnome-2.18/prefix/include/evolution-data-server-1.10 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonobo-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnome-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/orbit-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/bonobo-activation-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gconf/2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-vfs-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gnome-vfs-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/libxml2 -D_REENTRANT -I/home/lool/jhbuild-gnome-2.18/prefix/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include -DHAS_AVAHI -I/home/lool/jhbuild-gnome-2.18/prefix/include/ptlib -I/home/lool/jhbuild-gnome-2.18/prefix/include/ptclib -I/home/lool/jhbuild-gnome-2.18/prefix/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/opal -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -DHAS_SDL -DPTRACING -DNDEBUG -Wall -Os -g -fno-exceptions -felide-constructors -D_REENTRANT -g -O2 -MT gmcontacts-remote.lo -MD -MP -MF .deps/gmcontacts-remote.Tpo -c /home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gmcontacts/gmcontacts-remote.cpp  -fPIC -DPIC -o .libs/gmcontacts-remote.o
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gmcontacts/gmcontacts-remote.cpp:47:20: error: gmconf.h: No such file or directory
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gmcontacts/gmcontacts-remote.cpp: In function 'gboolean gnomemeeting_remote_addressbook_add(GmAddressbook*)':
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gmcontacts/gmcontacts-remote.cpp:122: error: 'gm_conf_get_string_list' was not declared in this scope
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gmcontacts/gmcontacts-remote.cpp:132: error: 'gm_conf_set_string_list' was not declared in this scope
...

This is due to the use of "-I../gmconf" as include specifier, but this will resolve to the buildir when srcdir != builddir, but gmconf.h is below srcdir, not builddir.

I'll attach a patch which uses $(top_srcdir) to compute the -I flag.

Bye,

Comment 1 Loïc Minier 2007-03-03 14:54:11 UTC

Created attachment 83819 [details] [review]
Include gmconf/ via $(srcdir)

Comment 2 Loïc Minier 2007-03-03 14:59:26 UTC

Created attachment 83821 [details] [review]
Include gmconf/ via $(srcdir) (take 2)

The build subsequently fails with:
make[5]: entrant dans le répertoire « /home/lool/jhbuild-gnome-2.18/build/ekiga/lib/gui »
/bin/sh ../../libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gui -DDATA_DIR=\""/home/lool/jhbuild-gnome-2.18/prefix/share"\" -DG_LOG_DOMAIN=\"Ekiga\" -DSHARE_DIR=\"/home/lool/jhbuild-gnome-2.18/prefix/share/ekiga\" -I../gmconf -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga -pthread -DORBIT2=1 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gtk-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gtk-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/atk-1.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/cairo -I/home/lool/jhbuild-gnome-2.18/prefix/include/pango-1.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/gconf/2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/orbit-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnome-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-vfs-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gnome-vfs-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonobo-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/bonobo-activation-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnomeui-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnomecanvas-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libart-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonoboui-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-keyring-1 -I/usr/include/freetype2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libxml2 -I/usr/include/libpng12   -DORBIT2=1 -pthread -I/home/lool/jhbuild-gnome-2.18/prefix/include/evolution-data-server-1.10 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonobo-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnome-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/orbit-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/bonobo-activation-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gconf/2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-vfs-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gnome-vfs-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/libxml2   -D_REENTRANT -I/home/lool/jhbuild-gnome-2.18/prefix/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include   -DHAS_AVAHI     -Os -MT gmconfwidgets.lo -MD -MP -MF .deps/gmconfwidgets.Tpo -c -o gmconfwidgets.lo /home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gui/gmconfwidgets.c
 gcc -DHAVE_CONFIG_H -I. -I../.. -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gui -DDATA_DIR=\"/home/lool/jhbuild-gnome-2.18/prefix/share\" -DG_LOG_DOMAIN=\"Ekiga\" -DSHARE_DIR=\"/home/lool/jhbuild-gnome-2.18/prefix/share/ekiga\" -I../gmconf -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga -pthread -DORBIT2=1 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gtk-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gtk-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/atk-1.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/cairo -I/home/lool/jhbuild-gnome-2.18/prefix/include/pango-1.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/gconf/2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/orbit-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnome-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-vfs-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gnome-vfs-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonobo-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/bonobo-activation-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnomeui-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnomecanvas-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libart-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonoboui-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-keyring-1 -I/usr/include/freetype2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libxml2 -I/usr/include/libpng12 -DORBIT2=1 -pthread -I/home/lool/jhbuild-gnome-2.18/prefix/include/evolution-data-server-1.10 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonobo-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnome-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/orbit-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/bonobo-activation-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gconf/2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-vfs-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gnome-vfs-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/libxml2 -D_REENTRANT -I/home/lool/jhbuild-gnome-2.18/prefix/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include -DHAS_AVAHI -Os -MT gmconfwidgets.lo -MD -MP -MF .deps/gmconfwidgets.Tpo -c /home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gui/gmconfwidgets.c  -fPIC -DPIC -o .libs/gmconfwidgets.o
In file included from /home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gui/gmconfwidgets.c:38:
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gui/gmconfwidgets.h:52:20: error: gmconf.h: No such file or directory
In file included from /home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gui/gmconfwidgets.c:38:
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gui/gmconfwidgets.h:88: error: expected declaration specifiers or '...' before 'GmConfEntry'
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gui/gmconfwidgets.h:111: error: expected declaration specifiers or '...' before 'GmConfEntry'

This is the same problem in a different dir which this second patch fixes as well.

Comment 3 Loïc Minier 2007-03-03 15:03:45 UTC

Created attachment 83822 [details] [review]
Fix relative include in accounts.cpp

The build subsequently fails with:
make[2]: entrant dans le répertoire « /home/lool/jhbuild-gnome-2.18/build/ekiga/src »
make  all-am
make[3]: entrant dans le répertoire « /home/lool/jhbuild-gnome-2.18/build/ekiga/src »
g++ -DHAVE_CONFIG_H -I. -I.. -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src -Iclients/ -Icomponents/ -Idevices/ -Iendpoints/ -Igui/ -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gmconf -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gmcontacts -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gui -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/xdap  -pthread -DORBIT2=1 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gtk-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gtk-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/atk-1.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/cairo -I/home/lool/jhbuild-gnome-2.18/prefix/include/pango-1.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/gconf/2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/orbit-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnome-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-vfs-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gnome-vfs-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonobo-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/bonobo-activation-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnomeui-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnomecanvas-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libart-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonoboui-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-keyring-1 -I/usr/include/freetype2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libxml2 -I/usr/include/libpng12   -DORBIT2=1 -pthread -I/home/lool/jhbuild-gnome-2.18/prefix/include/evolution-data-server-1.10 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonobo-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnome-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/orbit-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/bonobo-activation-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gconf/2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-vfs-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gnome-vfs-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/libxml2   -D_REENTRANT -I/home/lool/jhbuild-gnome-2.18/prefix/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include   -DHAS_AVAHI  -I/home/lool/jhbuild-gnome-2.18/prefix/include/ptlib -I/home/lool/jhbuild-gnome-2.18/prefix/include/ptclib -I/home/lool/jhbuild-gnome-2.18/prefix/include  -I/home/lool/jhbuild-gnome-2.18/prefix/include/opal -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -DHAS_SDL  -DPTRACING -DNDEBUG -Wall -Os -g -fno-exceptions -felide-constructors -D_REENTRANT -DDATA_DIR=\""/home/lool/jhbuild-gnome-2.18/prefix/share"\" -DSCHEMA_AGE=60     -g -O2 -MT accounts.o -MD -MP -MF .deps/accounts.Tpo -c -o accounts.o `test -f 'gui/accounts.cpp' || echo '/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src/'`gui/accounts.cpp
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src/gui/accounts.cpp:39:26: error: ../../config.h: Aucun fichier ou répertoire de ce type
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src/gui/accounts.cpp:48:21: error: manager.h: Aucun fichier ou répertoire de ce type
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src/gui/accounts.cpp:49:17: error: sip.h: Aucun fichier ou répertoire de ce type
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src/gui/accounts.cpp:50:18: error: h323.h: Aucun fichier ou répertoire de ce type
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src/gui/accounts.cpp:51:19: error: ekiga.h: Aucun fichier ou répertoire de ce type
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src/gui/accounts.cpp: In function ‘void account_toggled_cb(GtkCellRendererToggle*, gchar*, void*)’:

This is due to the include being a relative path to the source file but not to Makefile.am, which the attached patch fixes.

Comment 4 Loïc Minier 2007-03-03 15:06:51 UTC

Created attachment 83823 [details] [review]
Include endpoints/ via $(srcdir)

The build subsequently fails with:
make[2]: entrant dans le répertoire « /home/lool/jhbuild-gnome-2.18/build/ekiga/src »
make  all-am
make[3]: entrant dans le répertoire « /home/lool/jhbuild-gnome-2.18/build/ekiga/src »
g++ -DHAVE_CONFIG_H -I. -I.. -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src -Iclients/ -Icomponents/ -Idevices/ -Iendpoints/ -Igui/ -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gmconf -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gmcontacts -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/gui -I/home/lool/jhbuild-gnome-2.18/checkout/ekiga/lib/xdap  -pthread -DORBIT2=1 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gtk-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gtk-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/atk-1.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/cairo -I/home/lool/jhbuild-gnome-2.18/prefix/include/pango-1.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/gconf/2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/orbit-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnome-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-vfs-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gnome-vfs-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonobo-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/bonobo-activation-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnomeui-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnomecanvas-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libart-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonoboui-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-keyring-1 -I/usr/include/freetype2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libxml2 -I/usr/include/libpng12   -DORBIT2=1 -pthread -I/home/lool/jhbuild-gnome-2.18/prefix/include/evolution-data-server-1.10 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libbonobo-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/libgnome-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/orbit-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/bonobo-activation-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gconf/2 -I/home/lool/jhbuild-gnome-2.18/prefix/include/gnome-vfs-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/gnome-vfs-2.0/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/libxml2   -D_REENTRANT -I/home/lool/jhbuild-gnome-2.18/prefix/include -I/home/lool/jhbuild-gnome-2.18/prefix/include/glib-2.0 -I/home/lool/jhbuild-gnome-2.18/prefix/lib/glib-2.0/include   -DHAS_AVAHI  -I/home/lool/jhbuild-gnome-2.18/prefix/include/ptlib -I/home/lool/jhbuild-gnome-2.18/prefix/include/ptclib -I/home/lool/jhbuild-gnome-2.18/prefix/include  -I/home/lool/jhbuild-gnome-2.18/prefix/include/opal -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -DHAS_SDL  -DPTRACING -DNDEBUG -Wall -Os -g -fno-exceptions -felide-constructors -D_REENTRANT -DDATA_DIR=\""/home/lool/jhbuild-gnome-2.18/prefix/share"\" -DSCHEMA_AGE=60     -g -O2 -MT accounts.o -MD -MP -MF .deps/accounts.Tpo -c -o accounts.o `test -f 'gui/accounts.cpp' || echo '/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src/'`gui/accounts.cpp
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src/gui/accounts.cpp:48:21: error: manager.h: Aucun fichier ou répertoire de ce type
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src/gui/accounts.cpp:49:17: error: sip.h: Aucun fichier ou répertoire de ce type
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src/gui/accounts.cpp:50:18: error: h323.h: Aucun fichier ou répertoire de ce type
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src/gui/accounts.cpp:51:19: error: ekiga.h: Aucun fichier ou répertoire de ce type
/home/lool/jhbuild-gnome-2.18/checkout/ekiga/src/gui/accounts.cpp: In function ‘void account_toggled_cb(GtkCellRendererToggle*, gchar*, void*)’:

This is due to an include path being unspecified and hence relative to builddir instead of srcdir; the attached patch fixes this.

Comment 5 Loïc Minier 2007-03-03 15:18:36 UTC

Created attachment 83824 [details] [review]
Fix relative config.h includes

The ../../config.h and -I problems are repeated a couple of times, so here's a cumulative patch for the ../../config.h -> ../config.h move.

I think you shouldn't keep a config.h in SVN.

Comment 6 Loïc Minier 2007-03-03 15:20:59 UTC

Created attachment 83825 [details] [review]
Fix a bunch of includes to be relative to srcdir

The same goes for other instances of -I flags, cumulative patch for these failures attached.

Comment 7 Loïc Minier 2007-03-03 15:33:45 UTC

Created attachment 83826 [details] [review]
Fix relative config.h includes (take 2)

Final bunch of config.h include fixes.

Comment 8 Loïc Minier 2007-03-03 15:35:28 UTC

Created attachment 83827 [details] [review]
Fix a bunch of includes to be relative to srcdir (take 2)

Final bunch of -I fixes.

With these patches, ekiga now builds with srcdir != builddir for me.

Comment 9 Snark 2007-03-03 15:59:25 UTC

Hmmmm... don't we have *two* config.h ?

Comment 10 Loïc Minier 2007-03-03 16:23:40 UTC

Right; since the includes were of the form ../../config.h, these could only be aimed at including the top-level one, but since the build happens from src/Makefile.am and not src/*/Makefile.am, the ../.. seems incorrect.

It seems terribly risky to have two config.h if you ask me.

Comment 11 Snark 2007-03-03 18:50:49 UTC

Well, it's not risky unless someone tries to play with include paths ;-)

Comment 12 Loïc Minier 2007-03-03 19:20:56 UTC

Well, your call.

If you change your mind on having two config.h files, we can discuss renaming of the autotools config.h file (the AM_CONFIG_HEADER()'ed one) in a new bug; but this is orthogonal to fixing the -I flags.

Comment 13 Snark 2007-03-03 19:44:36 UTC

Eh... it's true another name for this file would be nice. It's a good occasion to get rid of this!

autotools-config.h ?

Comment 14 Jan Schampera 2007-03-17 09:06:47 UTC

Loïc, against which branch is that patch? HEAD?

J.

Comment 15 Loïc Minier 2007-03-17 09:15:12 UTC

It was against EKIGA_2_0_5 back then.

Comment 16 Snark 2007-07-25 19:53:55 UTC

Should I make it a gnome-love bug? That looks so stupid to be stuck this long for such a thing :-/

Comment 17 Snark 2007-07-25 19:55:42 UTC

What's the difference between the two patches, by the way?

Comment 18 Snark 2007-10-26 18:37:50 UTC

Hmmm... months went by, we have changed quite a few things... assigning to myself, but perhaps this bug is already dead.

Comment 19 Snark 2008-08-30 17:12:43 UTC

Uh... if it's assigned but not to myself, I can't see it :-(

This time really assigning to myself... don't know when I'll have the time to look at it though.

Comment 20 Snark 2008-08-31 13:27:08 UTC

I worked on it : I have problems with the dbus service files. I should find another project with the same problem and see how they do.

Comment 21 Snark 2008-08-31 13:29:47 UTC

I hadn't even look at the patches : they bitrotted since long ; sorry :-(