After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 414065 - use cover art info from last.fm stream metadata
use cover art info from last.fm stream metadata
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks: 412853
 
 
Reported: 2007-03-02 23:45 UTC by Jonathan Matthew
Modified: 2007-03-03 05:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (4.97 KB, patch)
2007-03-02 23:53 UTC, Jonathan Matthew
none Details | Review
working patch (5.33 KB, patch)
2007-03-03 00:53 UTC, Jonathan Matthew
committed Details | Review

Description Jonathan Matthew 2007-03-02 23:45:01 UTC
The last.fm stream metadata includes cover art URIs, so we might as well use them.
Comment 1 Jonathan Matthew 2007-03-02 23:53:59 UTC
Created attachment 83776 [details] [review]
patch

also adds the ability to indicate that no cover image exists by emitting rb:coverArt-uri with an empty URI.
Comment 2 Jonathan Matthew 2007-03-03 00:53:54 UTC
Created attachment 83779 [details] [review]
working patch

makes the empty URI notification thing actually work
Comment 3 James "Doc" Livingston 2007-03-03 04:48:12 UTC
Looks good to me.
Comment 4 Jonathan Matthew 2007-03-03 05:57:42 UTC
Committed to svn with some additional changes to clear the cover image in the tooltip on rb:coverArt signals with no pixbuf.