After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 413443 - gnome-calculator is not publically visible icon
gnome-calculator is not publically visible icon
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
5.8.x
Other Linux
: Normal trivial
: ---
Assigned To: Rich Burridge
Rich Burridge
Depends on:
Blocks:
 
 
Reported: 2007-03-01 14:08 UTC by Stanislav Brabec
Modified: 2007-03-28 12:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Patch to hopefully fix the problem. (383 bytes, patch)
2007-03-12 23:24 UTC, Rich Burridge
committed Details | Review

Description Stanislav Brabec 2007-03-01 14:08:51 UTC
gcalctool.desktop referes to gnome-calculator, which does not exist in any of public icon search paths ($(datadir)/pixmaps or $(datadir)/icons/hicolor/*/apps).

Package gnome-icon-theme provides this icon in GNOME-only path $(datadir)/icons/gnome/*/apps.

Fix:

Either provide icon in a public path (preferred) or disable gcalctool for all desktops except GNOME.
Comment 1 Rich Burridge 2007-03-12 16:40:07 UTC
Thanks Stanislav. Any idea how I "disable gcalctool for all
desktops except GNOME?"
Comment 2 Andreas Nilsson 2007-03-12 19:00:40 UTC
Could the gcalctool.desktop refer to accesories-calculator instead perhaps, a icon that exists in all icon themes that follows the icon-naming-spec on freedesktop.org.
Comment 3 Vincent Untz 2007-03-12 19:48:04 UTC
(In reply to comment #1)
> Thanks Stanislav. Any idea how I "disable gcalctool for all
> desktops except GNOME?"

You can do this with this line in the .desktop file:
OnlyShowIn=GNOME;

However, Andreas is probably right about the name of the icon.
Comment 4 Rich Burridge 2007-03-12 20:00:55 UTC
Thanks Andreas/Vincent. I'll put together a patch (probably
tomorrow) and check it into SVN trunk/HEAD.
Comment 5 Rodney Dawes 2007-03-12 20:02:33 UTC
Yes. For basic apps that make up the base desktop, like the calculator, file manager, etc... we have some names in the icon-naming-spec. This is so that under KDE their calculator gets shown, and gets the icon, and under GNOME we get gcalctool with the icon. As Vincent said, OnlyShowIn=GNOME is how that gets set. And as Andreas suggested, accessories-calculator would be the name to use in the .desktop file. This icon is provided by the theme, rather than gcalctool.
Comment 6 Rich Burridge 2007-03-12 23:24:37 UTC
Created attachment 84466 [details] [review]
Patch to hopefully fix the problem.

Vincent/Rodney, could you eyeball this and check that it's what's needed please?
It seems to work okay for me. Thanks.
Comment 7 Rich Burridge 2007-03-28 12:34:03 UTC
Patch committed. Closing as FIXED.