After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 411125 - bad name sorting in "Contacts" for vowel with accents
bad name sorting in "Contacts" for vowel with accents
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Contacts
2.8.x (obsolete)
Other All
: High critical
: ---
Assigned To: Milan Crha
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-02-23 09:07 UTC by Maurício Luis Grignoli
Modified: 2007-09-21 06:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
sort contacts (134.96 KB, image/png)
2007-04-24 10:19 UTC, Maurício Luis Grignoli
  Details
proposed evo patch (712 bytes, patch)
2007-09-07 12:16 UTC, Milan Crha
rejected Details | Review
proposed evo patch (26.04 KB, patch)
2007-09-19 14:40 UTC, Milan Crha
committed Details | Review

Description Maurício Luis Grignoli 2007-02-23 09:07:14 UTC
What were you doing when the application crashed?
Referente a ordenação dos nomes nos "Contatos", quando coloco uma vogal com ascento, ela vai para o final da lista, tendo como referência, o ascento e não a vogal.


Distribution: Ubuntu 6.10 (edgy)
Gnome Release: 2.16.1 2006-10-02 (Ubuntu)
BugBuddy Version: 2.16.0
Comment 1 André Klapper 2007-02-24 14:34:10 UTC
sorry, can you please translate this to english? thanks in advance.
(gnome 2.18's bug-buddy will have a hint to please report in english language, if possible, so the users will hopefully save some time)
Comment 2 Susana 2007-02-24 15:50:02 UTC
Translation:
Regarding name sorting in "Contacts", when I use a vowel with an accent (accented character) the contact goes to the end of the list using the accent as a sorting reference instead of the vowel.
Comment 3 Sebastien Bacher 2007-04-23 20:17:01 UTC
Ubuntu bug on https://bugs.launchpad.net/ubuntu/+source/evolution/+bug/106160

"Binary package hint: evolution

Contacts viewed by Phone List view doesn't sort fields correctly. Instead it allways discriminates characters containing diacritic like czech characters ěščřž.
...
http://librarian.launchpad.net/7333245/snapshot5.png
Screenshot of Evolution Contact List

Ubuntu is of version Edgy, evolution is of version 2.8.1-0ubuntu4.1. Screenshot included showing the end of the contact list."
Comment 4 Maurício Luis Grignoli 2007-04-24 10:19:37 UTC
Created attachment 86913 [details]
sort contacts

Problem confirmed. Look at the name "Éric" out of order.
Comment 5 Milan Crha 2007-09-07 12:16:32 UTC
Created attachment 95119 [details] [review]
proposed evo patch

for evolution;

I looked on all calls for e_str_compare and it's used only in widgets/table, so I think this change is safe.
Comment 6 Matthew Barnes 2007-09-07 13:26:59 UTC
Instead of chaning e_str_compare(), call e_collate_compare() instead.
Comment 7 Matthew Barnes 2007-09-07 13:27:32 UTC
s/chaning/changing/
Comment 8 Milan Crha 2007-09-07 14:08:30 UTC
Hm, if you need to fix it in this way, then it should be better to change all .etspec files and use 'compare="collate"' instead of 'compare="string"', but I don't know where should be better to use strcmp than g_utf8_collate, especially with ETable, where it is prepared for utf8, I think.
I meant, the code change is much shorter than the proper definition change.
Comment 9 Milan Crha 2007-09-19 14:40:42 UTC
Created attachment 95852 [details] [review]
proposed evo patch

for evolution's *.etspec files

No code change at all, I just changed *.etspec files, it's using compare="collate" instead of compare="string" now.
Comment 10 Matthew Barnes 2007-09-19 15:38:34 UTC
Patch looks good to me but I'll defer to Srini for approval.
Comment 11 Srinivasa Ragavan 2007-09-21 06:30:39 UTC
Looks good to me also. I dont see any  problem straight away. So commit to head/stable.
Comment 12 Milan Crha 2007-09-21 06:58:53 UTC
Committed to trunk. Committed revision 34289.
Committed to gnome-2-20 branch. Committed revision 34290.