After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 410002 - void pointer arithmetics in some source files
void pointer arithmetics in some source files
Status: RESOLVED FIXED
Product: ORBit2
Classification: Deprecated
Component: general
2.14.x
Other All
: Normal normal
: ---
Assigned To: ORBit maintainers
ORBit maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-20 13:22 UTC by Roland Illig
Modified: 2007-02-28 17:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch 1 (5.38 KB, patch)
2007-02-20 13:23 UTC, Roland Illig 		none Details | Review
patch 2 (973 bytes, patch)
2007-02-20 13:23 UTC, Roland Illig 		none Details | Review

Description Roland Illig 2007-02-20 13:22:42 UTC 
While the GNU C compiler accepts void pointer arithmetics, other compilers are stricter and fail compiling. Therefore, the following patches are needed.

By the way, the code in those files looks rather redundant with all those ((casts)(to)(other)(pointers)). You should probably fix that up, maybe using the ADDSIZE macro that's in the patch.

Roland
Comment 1 Roland Illig 2007-02-20 13:23:01 UTC 
Created attachment 82949 [details] [review]
patch 1
Comment 2 Roland Illig 2007-02-20 13:23:13 UTC 
Created attachment 82950 [details] [review]
patch 2
Comment 3 Roland Illig 2007-02-20 13:25:03 UTC 
By the way, the patches are against 2.14.5. I hope there haven't been too many changes to the code since then.

Roland
Comment 4 Michael Meeks 2007-02-20 15:13:08 UTC 
Looks rather nice :-) Thanks Roland.
If make check passes this should be safe, AFAIR we have some good regression tests for this lot.
Comment 5 Kjartan Maraas 2007-02-28 17:18:07 UTC 
Commited after testing make check. No regressions were found.