After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 408591 - Add wbmp to supported image types
Add wbmp to supported image types
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
2.19.x
Other Linux
: Normal enhancement
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-16 13:56 UTC by Sven Arvidsson
Modified: 2007-08-13 08:59 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Patch to add wbmp to eog.desktop (906 bytes, patch)
2007-02-16 13:56 UTC, Sven Arvidsson
committed Details | Review
WBMP image (132 bytes, image/vnd.wap.wbmp)
2007-02-17 00:19 UTC, Sven Arvidsson
  Details

Description Sven Arvidsson 2007-02-16 13:56:03 UTC
This is Debian bug 270595
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=270595

Can wbmp be added as a supported image? EOG already seems to support this format, and the MIME type was recently added to shared-mime-info*.

Some sample images are available here,
http://www.todoso.co.uk/wbmp/index.htm

* https://bugs.freedesktop.org/show_bug.cgi?id=9186
Comment 1 Sven Arvidsson 2007-02-16 13:56:48 UTC
Created attachment 82679 [details] [review]
Patch to add wbmp to eog.desktop
Comment 2 Claudio Saavedra 2007-02-17 00:15:11 UTC
I couldn't find any wbmp image in the link you provided. All the images in that page are simple gif files. Could you attach to this bug a wbmp image to make sure EOG can open that format? Thanks.
Comment 3 Sven Arvidsson 2007-02-17 00:19:55 UTC
Created attachment 82712 [details]
WBMP image

The images are linked from that site, might be easy to overlook. Anyway, I'm attaching a sample image as requested.
Comment 4 Felix Riemann 2007-02-17 10:55:01 UTC
Although it's correct and works it would make us depend on shared-mime-info-0.20+.
Unfortunately the current "global" minimally required version for the GNOME Desktop is 0.19 (see http://live.gnome.org/TwoPointSeventeen/ExternalDependencies).

So I guess we have to ask for a raising of that dep first.
We then should additionally check for it in configure as we get some strange behavior (missing thumbnails, crashes in eog-ng) if s-m-i is not recent enough.
Comment 5 Claudio Saavedra 2007-06-25 16:43:28 UTC
I think the s-m-i version raising was propossed somewhere in d-d-l. Updating version in the meantime.
Comment 6 Felix Riemann 2007-08-13 08:59:05 UTC
http://live.gnome.org/TwoPointNineteen/ExternalDependencies lists 0.22 as the minimum s-m-i version for 2.20.

So I committed the patch to trunk and made sure that s-m-i is recent enough (0.20+).

2007-08-13  Felix Riemann  <>

	* configure.ac: Make sure s-m-i >= 0.20 is installed.
	* data/eog.desktop.in.in: Add WBMP to supported filetypes.
	Fixes bug #408591 (Sven Arvidsson).

----
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report and patch.