After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 408035 - volume popup composite use requires to restart gnome-settings-daemon
volume popup composite use requires to restart gnome-settings-daemon
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] settings-daemon
2.17.x
Other Linux
: Normal minor
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-14 22:46 UTC by Sebastien Bacher
Modified: 2007-03-26 19:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
rebuild the media keys window if necessary (2.18 KB, patch)
2007-03-08 18:33 UTC, Jens Granseuer
none Details | Review

Description Sebastien Bacher 2007-02-14 22:46:53 UTC
That bug has been described on https://launchpad.net/ubuntu/+source/control-center/+bug/83724

"...
The transparent window is used after beryl start, not before.
But I report because if I close beryl the transparent window is still
used or if I use the sound manager before beryl start, after starting
beryl it stay normal (not transparent)
..."
Comment 1 Jens Granseuer 2007-02-15 18:46:30 UTC
Currently, the decision to use compositing or not is only made once - when the window is shown for the first time. To fix this, we'd need to check for compositing every time before unhiding the window and manipulate it accordingly if the mode has changed. (We could also destroy and recreate the window with each expose, but I don't think we'd want to do that.)

I'm not sure if manipulating the window when composited -> non-composited and vice versa works well. A first rough patch is easily done, but would require somebody with a composite setup to verify and work out the kinks.
Comment 2 Jens Granseuer 2007-03-08 18:33:42 UTC
Created attachment 84256 [details] [review]
rebuild the media keys window if necessary

Here's a patch that refreshes the window if composite mode changed. As I said I can't test-drive this myself, so some sort of verification would be nice.
Comment 3 Sebastien Bacher 2007-03-26 10:37:06 UTC
the patch works fine on my Ubuntu desktop
Comment 4 Jens Granseuer 2007-03-26 19:05:37 UTC
Thanks for testing.

2007-03-26  Jens Granseuer  <jensgr@gmx.net>

        * gnome-settings-multimedia-keys.c: (dialog_init):
        * gsd-media-keys-window.c: (gsd_media_keys_window_is_valid),
        (initialize_alpha_mode):
        * gsd-media-keys-window.h: rebuild the media window if the state of
        composite has changed (fixes bug #408035)