After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 406996 - Topics with commas not handled correctly in Add Bookmark dialog
Topics with commas not handled correctly in Add Bookmark dialog
Status: RESOLVED WONTFIX
Product: epiphany
Classification: Core
Component: Bookmarks
unspecified
Other Linux
: Normal minor
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 755378
 
 
Reported: 2007-02-12 09:13 UTC by Reinout van Schouwen
Modified: 2016-10-07 21:27 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
Disallowing commas in topic names (3.02 KB, patch)
2010-03-15 20:04 UTC, José Millán Soto 		reviewed Details | Review

Description Reinout van Schouwen 2007-02-12 09:13:44 UTC 
1. Go to the Bookmarks editor
2. Create a new topic with the name "One, two"
3. Visit a random webpage and press Ctrl+D (Add bookmark)
Optionally expand the topic chooser.
4. Begin type "One" in the topic field
5. Select "One, two" from the dropdown

Expected results: 
Bookmark is filed under the topic "One, two"

Actual results:
Bookmark is filed without a topic

You can even make it more complicated by having a topic "One" and a topic "One, two". In the above scenario the bookmark will then be filed under "One" where you meant it to go under "One, two".

Suggested simple workaround: disallow commas in topic names everywhere.
Comment 1 José Millán Soto 2010-03-15 20:04:24 UTC 
Created attachment 156216 [details] [review]
Disallowing commas in topic names

This patch disallows commas in topic names, so it prevents the problem described in this bug.
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2010-03-15 23:51:53 UTC 
I think we should show a tooltip or something when the user tries to enter an invalid char. So when his char doesn't go through he can see this tooltip and understand why.
Comment 3 Michael Catanzaro 2016-09-28 16:49:30 UTC 
Hi, the bookmarks code has been rewritten from scratch. When you have a convenient opportunity to test the new version of the code (which will be present in Epiphany 3.23.1) please check to see if your issue is still a problem, and reply here. Thanks!
Comment 4 Michael Catanzaro 2016-10-07 21:27:43 UTC 
Hi, this is a mass close of all bugs in the NEEDINFO state. If you think this bug was closed improperly, just leave a comment, thanks!