GNOME Bugzilla – Bug 405916
Fix all compiler warnings in evolution-exchange
Last modified: 2007-03-29 17:55:06 UTC
The summary pretty much says it all. I tried to put a little more effort into it than the usual cast-a-thon for patches like this. I'm not sure I understand Evolution's (especially Camel's) preference for GByteArray over GString for character data. Coupled with sloppy handling of pointer signedness, this seems to account for a large percentage of warnings in Evolution and co. Anyway, I'll be compiling future Fedora releases of this package with -Werror.
Created attachment 82187 [details] [review] Proposed patch
Created attachment 82202 [details] [review] Revised patch I missed a few warnings due to the configure options I was using the first time. Here's a revised patch that fixes a few more. With this patch I was able to build a Fedora Core package with the -Werror compiler option.
FYI, no new compiler warnings in Evolution-Exchange-2.9.91. Attachment #82202 [details] is still up-to-date.
Created attachment 82576 [details] [review] Revised patch Spoke too soon. Building on a 64-bit arch revealed a couple more: cc1: warnings being treated as errors mail-utils.c: In function 'mail_util_extract_transport_headers': mail-utils.c:211: warning: field precision should have type 'int', but argument 2 has type 'long int' mail-utils.c:211: warning: field precision should have type 'int', but argument 4 has type 'long int' mail-utils.c:214: warning: field precision should have type 'int', but argument 2 has type 'long int' This revision, finally, fixes all warnings on all arches supported by Fedora.
Committed to Subversion trunk, revision 1332.