After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 402847 - Totem gstreamer backend doesn't check if screen != NULL and crash
Totem gstreamer backend doesn't check if screen != NULL and crash
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: GStreamer backend
2.17.x
Other Linux
: Normal normal
: ---
Assigned To: Maintainer alias for GStreamer component of Totem
Maintainer alias for GStreamer component of Totem
Depends on:
Blocks:
 
 
Reported: 2007-01-31 15:04 UTC by did447
Modified: 2007-01-31 16:02 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
totem-trunk-check-screen.patch (423 bytes, patch)
2007-01-31 15:15 UTC, Bastien Nocera 		none Details | Review

Description did447 2007-01-31 15:04:44 UTC 
How to reproduce:
in totem enable 'visual effect for audio'

in a terminal:

totem-video-indexer foo.wav

(totem-video-indexer:9944): Gdk-CRITICAL **: gdk_screen_get_width: assertion `GDK_IS_SCREEN (screen)' failed

(totem-video-indexer:9944): Gdk-CRITICAL **: gdk_screen_get_height: assertion `GDK_IS_SCREEN (screen)' failed


bug in: 
totem/src/backend/bacon-video-widget-gst-0.10.c get_visualization_size()


cf:

https://bugs.launchpad.net/ubuntu/+source/totem/+bug/80801
Comment 1 Bastien Nocera 2007-01-31 15:15:23 UTC 
Created attachment 81597 [details] [review]
totem-trunk-check-screen.patch

Does this work?
Comment 2 did447 2007-01-31 15:59:59 UTC 
yes it does.
Comment 3 Bastien Nocera 2007-01-31 16:02:55 UTC 
Thanks.

2007-01-31  Bastien Nocera  <hadess@hadess.net>

        * src/backend/bacon-video-widget-gst-0.10.c:
        (get_visualization_size): avoid getting criticals when we're not
        in video playback mode, and we check for the vis. qualities,
        spotted by <did447@gmail.com> (Closes: #402847)