After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 400968 - "Install theme" alert comments
"Install theme" alert comments
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] theme-manager
2.17.x
Other All
: Normal minor
: ---
Assigned To: Thomas Wood
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-26 11:41 UTC by Calum Benson
Modified: 2007-12-22 16:40 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Make error theme installer dialogs more complient with the HIG. (5.24 KB, patch)
2007-12-22 15:38 UTC, Thomas Wood 		committed Details | Review

Description Calum Benson 2007-01-26 11:41:15 UTC 
Pushing upstream from OpenSolaris:

- Click on install theme, theme installation window pops up
- Choose an invalid file
- Alert window pops up

Observations on error window:

- It's not in HIG format, and the message is a bit terse.  "This does not appear to be a valid theme" or something would be a little more helpful.

- Clicking on "ok" closes both the alert and the file chooser, rather than just the alert.
Comment 1 Thomas Wood 2007-01-27 10:47:01 UTC 
Valid comments. Might also be a nice idea to add a filter to the filechooser so that it only shows files with the extensions it's going to accept.
Comment 2 Thomas Wood 2007-12-22 15:38:50 UTC 
Created attachment 101460 [details] [review]
Make error theme installer dialogs more complient with the HIG.
Comment 3 Thomas Wood 2007-12-22 16:40:08 UTC 
Committed patch, with modifications based on suggestions by Jens.

The patch also closes the file chooser before popping up the error message, thus removing any confusion about the error message closing the file chooser. The alternative (allow user to choose a new file after error) would require some heavy re-factoring, as the file often has to be copied to a temporary location before analysis. Keeping the file chooser dialog open during this process would mean the file transfer dialog would also appear over the top of it.