After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 399991 - Fit button doesn't scale up, only down
Fit button doesn't scale up, only down
Status: RESOLVED NOTABUG
Product: eog
Classification: Core
Component: general
2.16.x
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
: 519751 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-01-23 22:42 UTC by Sven Arvidsson
Modified: 2008-03-03 16:41 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Description Sven Arvidsson 2007-01-23 22:42:49 UTC 
This bug was filed in the Debian BTS.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=248447

"The 'Fit' button does exactly the same as the 'Normal' button. It doesn't do what I expect: fit the image to the size of the current window.

[...]

It is still there, exactly as it was before. Just view a small image (say 12x12 pixels). When hitting "Best Fit", nothing happens, it doesn't scale it up to fit in the bigger window.

I can only make it fit better by clicking "Zoom In". When I zoom in a  lot and then click Best Fit, it zooms out to 100% again. (If I want 100%, I will click on Normal Size...)"

This is an old Debian bug, it it still seems to apply to eog 2.16.
Comment 1 Claudio Saavedra 2007-01-24 05:55:08 UTC 
It depends on how do you define "best fit". If best fit is intended to make the image completely visible in the window, then upscaling is not needed images smaller than the window. If it is intended to make images fit *exactly* on the window, no matter their size, then yes, this is a bug.

According with the EOG API, it is easy to fix. If we agree on what is "best fit", we are done.
Comment 2 Sven Arvidsson 2007-01-24 11:30:17 UTC 
I was thinking about the same thing. 

It's worth to notice, gthumb seems to treat "best fit" as adjust to the window. Whatever the outcome of this bug, it would be a good idea to have this consistent between image viewers in GNOME.
Comment 3 Lucas Rocha 2007-01-24 12:10:37 UTC 
Best fit means: if the image if bigger that the available window size, adjust it to fit the window size. If the image is smaller than the available size, it should *not* zoom in to fit the window size. This is NOTABUG but a design choice.

Sven, I suggest you to file a bug about this for gthumb if it's inconsistent.
Comment 4 Felix Riemann 2008-03-03 16:41:15 UTC 
*** Bug 519751 has been marked as a duplicate of this bug. ***