After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 399282 - Fix the gtk_style_attach call on vte_terminal_realize in the gnome 2.16 branch, too
Fix the gtk_style_attach call on vte_terminal_realize in the gnome 2.16 bran...
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other Linux
: Immediate blocker
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-01-22 07:22 UTC by Mariano Suárez-Alvarez
Modified: 2007-02-28 21:12 UTC
See Also:
GNOME target: 2.16.x
GNOME version: 2.15/2.16

Attachments
Use the return of gtk_style_attach. (410 bytes, patch)
2007-01-22 09:27 UTC, Chris Wilson 		committed Details | Review
GNOME 2.14 / vte 0.12 backport (857 bytes, patch)
2007-02-26 10:36 UTC, Loïc Minier 		none Details | Review

Description Mariano Suárez-Alvarez 2007-01-22 07:22:16 UTC 
In the commit <http://svn.gnome.org/viewcvs/vte/trunk/src/vte.c?rev=1443&r1=1438&r2=1443>, Chris fixed a broken call to gtk_style_attach (without saying so in the changelog entry... :-) ) 

chpe correctly points out that that broken call is probably what is causing our many-dup'ed g-t bug 353498. The change should go into the gnome-2-16 branch (and is maybe probably worth a release?).
Comment 1 Chris Wilson 2007-01-22 09:27:10 UTC 
Created attachment 80868 [details] [review]
Use the return of gtk_style_attach.

Sorry, I had an outstanding bug report on this for sooo long that I thought it was just me being pedantic.
Comment 2 André Klapper 2007-01-23 02:39:22 UTC 
blocker that needs to be fixed for 2.16.3.
Comment 3 Behdad Esfahbod 2007-01-23 03:45:30 UTC 
2007-01-22  Behdad Esfahbod  <behdad@gnome.org>

        Bug 399282 – Fix the gtk_style_attach call on vte_terminal_realize in
        the gnome 2.16 branch, too
        Bug 353498 – crash in Terminal: changing icon theme

        * src/vte.c (vte_terminal_realize): Fix the long time crasher.
Comment 4 Loïc Minier 2007-02-26 10:36:40 UTC 
Created attachment 83378 [details] [review]
GNOME 2.14 / vte 0.12 backport
Comment 5 Behdad Esfahbod 2007-02-28 21:12:45 UTC 
Feel free to commit to that branch.