After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 398414 - Printing to file with multiple pages per sheet
Printing to file with multiple pages per sheet
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Printing
2.10.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Depends on:
Blocks: 395573
 
 
Reported: 2007-01-19 16:51 UTC by Carlos Garcia Campos
Modified: 2008-01-02 18:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Proposed patch (3.14 KB, patch)
2007-05-20 15:19 UTC, Carlos Garcia Campos
none Details | Review
Updated patch (3.83 KB, patch)
2007-05-20 15:50 UTC, Carlos Garcia Campos
needs-work Details | Review
New patch (4.71 KB, patch)
2007-05-26 09:40 UTC, Carlos Garcia Campos
committed Details | Review

Description Carlos Garcia Campos 2007-01-19 16:51:48 UTC
It's impossible to select more than one page per sheet from printing dialog when printing to a file. This capability could be implemented by the application, so even if it's not supported directly by gtk+ we should be able to enable it manually. A new capability GTK_PRINT_CAPABILITY_NUMBER_UP or something like that could be added, so that we'll be able to enable this feature with gtk_print_unix_dialog_set_manual_capabilities().
Comment 1 Carlos Garcia Campos 2007-05-20 15:19:01 UTC
Created attachment 88489 [details] [review]
Proposed patch

This patch fixes the problem. It adds a new capability ( GTK_PRINT_CAPABILITY_NUMBER_UP).
Comment 2 Carlos Garcia Campos 2007-05-20 15:50:49 UTC
Created attachment 88491 [details] [review]
Updated patch

I forgot to add documentation for the new capability.
Comment 3 Matthias Clasen 2007-05-26 04:56:02 UTC
This is not how the other capabilities work - What I would expect here is that the print dialog sets the sensitivity of the n_up option depending on the capability,
and print backends report it - ie the cups backend would have to add the n_up
capability, and the file backend would not. 
Comment 4 Carlos Garcia Campos 2007-05-26 09:40:59 UTC
Created attachment 88838 [details] [review]
New patch

Agree, I never liked the option menu with only one option. So, here is an updated patch.
Comment 5 Matthias Clasen 2007-05-28 05:58:09 UTC
The documentation for the new capability should say what it stands for, not just "Since 2.12". Other than that, it looks good to me, please commit with the doc change.
Comment 6 Carlos Garcia Campos 2007-05-28 10:40:59 UTC
2007-05-28  Carlos Garcia Campos  <carlosgc@gnome.org>

        * gtk/gtkprinter.[ch]: Add new capability
        GTK_PRINT_CAPABILITY_NUMBER_UP.
        * docs/reference/gtk/tmpl/gtkprintunixdialog.sgml:
        * gtk/gtkprintunixdialog.c: (update_dialog_from_capabilities):
        * modules/printbackends/file/gtkprintbackendfile.c:
        (file_printer_get_options), (file_printer_get_settings_from_options):
        * modules/printbackends/cups/gtkprintbackendcups.c:
        (cups_printer_get_capabilities): Add a new print capability to specify
        whether print dialog will offer printing multiple pages per sheet. (#398414)
Comment 7 Christian Persch 2008-01-02 18:35:04 UTC
Shouldn't GTK_PRINT_CAPABILITY_NUMBER_UP also have been added to the capabilities in gtkprintoperation-unix.c (get_print_dialog) ?