After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 398241 - gtk_menu_shell_insert should emit "add" signal
gtk_menu_shell_insert should emit "add" signal
Status: RESOLVED DUPLICATE of bug 616850
Product: gtk+
Classification: Platform
Component: Widget: GtkMenu
2.91.x
Other All
: Normal minor
: ---
Assigned To: gtk-bugs
gtk-bugs
: 316541 (view as bug list)
Depends on:
Blocks: 372545
 
 
Reported: 2007-01-19 03:08 UTC by Li Yuan
Modified: 2014-12-08 12:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to emit "add" signal (660 bytes, patch)
2007-01-19 03:09 UTC, Li Yuan 		none Details | Review

Description Li Yuan 2007-01-19 03:08:49 UTC 
gtk_menu_shell_insert only set child's parent, but not emit gtkcontainer's "add" signal. In a11y part, we never notice user add a menu item.
Comment 1 Li Yuan 2007-01-19 03:09:48 UTC 
Created attachment 80677 [details] [review]
patch to emit "add" signal
Comment 2 Li Yuan 2007-01-22 08:25:05 UTC 
Somebody help me to review this patch?
Thanks in advance.
Comment 3 Harry Lu 2007-02-16 02:36:37 UTC 
Could someone review the patch?
Comment 4 Philip Withnall 2007-05-26 16:50:01 UTC 
Patch 80677 applies cleanly. Reviewing it would take little time.

(Working on http://mail.gnome.org/archives/gtk-devel-list/2007-March/msg00148.html)
Comment 5 Li Yuan 2007-09-18 03:59:06 UTC 
Any updates?
Comment 6 Claudio Saavedra 2009-05-15 11:00:32 UTC 
*** Bug 316541 has been marked as a duplicate of this bug. ***
Comment 7 Javier Jardón (IRC: jjardon) 2010-11-30 03:15:20 UTC 
Still valid
Comment 8 Thomas Martitz 2014-05-24 13:00:50 UTC 
I added https://bugzilla.gnome.org/show_bug.cgi?id=730687 which seems kind of related.
Comment 9 Matthias Clasen 2014-12-08 12:07:08 UTC 

*** This bug has been marked as a duplicate of bug 616850 ***