GNOME Bugzilla – Bug 398100
Deprecate STATE_ARMED
Last modified: 2021-07-05 10:45:30 UTC
The issue of whether the state armed is useful has been raised. We should consider deprecating API for this state. Note a corresponding ATK bug has not yet being filed so discussion can happen here for now.
IMO if it doesn't have any known use case then it should be deprecated so as not to cause future AT and app developers extra work. It will simply cause misunderstandings.
Agreed. If indeed there are no good use cases. FWIW here is the JFC use of armed: "In details, the state model for buttons works as follows when used with the mouse: Pressing the mouse on top of a button makes the model both armed and pressed. As long as the mouse remains down, the model remains pressed, even if the mouse moves outside the button. On the contrary, the model is only armed while the mouse remains pressed within the bounds of the button (it can move in or out of the button, but the model is only armed during the portion of time spent within the button). A button is triggered, and an ActionEvent is fired, when the mouse is released while the model is armed - meaning when it is released over top of the button after the mouse has previously been pressed on that button (and not already released). Upon mouse release, the model becomes unarmed and unpressed." (from http://java.sun.com/javase/6/docs/api/javax/swing/ButtonModel.html)
Ping.
Orca is currently using the ARMED state in the script for the Java platform. The comment around the use of the ARMED state is this: # This is a workaround for a java-access-bridge bug (Bug 355011) # where popup menu events are not sent to Orca. # # When a root pane gets focus, a popup menu may have been invoked. # If there is a popup menu, give locus of focus to the armed menu # item. # If a fix for bug 355011 can help eliminate the use of ARMED for Orca, then I would not object to deprecating the ARMED state.
OK, I would mark bug 355011 blocks this one.
[Resetting QA Contact to newly introduced "at-spi-maint@gnome.bugs". Reason: So far it was impossible to watch changes in at-spi bug reports without following all the specific persons (Li Yuan, Bill Haneman, Jeff Wai, ...) and also their activity outside of at-spi reports. IMPORTANT: Anyone interested in following all bug activity (including all maintainers) must watch the "at-spi-maint@gnome.bugs" dummy user by adding it to the 'Users to watch' list under Preferences->Email preferences. This is also the default procedure nowadays in GNOME when setting up new products.]
[Mass-resetting default assignee, see bug 705890. Please reclaim this bug report by setting the assignee to yourself if you still plan to work on this. Thanks!]
I'm going to go ahead and close this because it concerns a very old version. Feel free to open a new bug if the problem persists.
STATE_ARMED is useless. And getting state-changed signals for it doubly so. Reopening.
Thanks for the update.
Created attachment 291102 [details] [review] Proposed patch This documents that the state is now deprecated. Similar documentation was added to ATK.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/at-spi2-core/-/issues/ Thank you for your understanding and your help.