After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 397776 - Scrolling dropdown in sidebar does not switch entries
Scrolling dropdown in sidebar does not switch entries
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
2.16.x
Other Linux
: Normal trivial
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-01-17 21:25 UTC by Sven Arvidsson
Modified: 2007-06-28 22:28 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Use a default GtkComboBox instead of the custom button menu combination (16.20 KB, patch)
2007-05-05 10:40 UTC, Jan Arne Petersen
none Details | Review
v2: Rework padding/border (16.73 KB, patch)
2007-06-28 19:47 UTC, Jan Arne Petersen
none Details | Review
v3: use 6 6 6 0 border (17.23 KB, patch)
2007-06-28 21:40 UTC, Jan Arne Petersen
accepted-commit_now Details | Review

Description Sven Arvidsson 2007-01-17 21:25:41 UTC
This bug was filed in the Debian BTS.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=407046

"When the sidebar is enabled and you scroll the Playlist/Properties dropdown
element, totem skips through the currently played song. But it should switch
between the entries of this dropdown box instead since this is the default and
expected GTK behaviour for hovered dropdown/combobox elements."

I'm not sure if this is an issue with Totem or GTK+ as at least Nautilus has a similar issue. (The path selection button in the lower left of spatial Nautilus doesn't respond to scrolling either.)
Comment 1 Jan Arne Petersen 2007-05-05 10:40:04 UTC
Created attachment 87599 [details] [review]
Use a default GtkComboBox instead of the custom button menu combination
Comment 2 Philip Withnall 2007-06-15 12:42:48 UTC
Patch looks OK to me, although I could quibble over the new padding between the combobox and the playlist box, which looks a little much to me.
Comment 3 Jan Arne Petersen 2007-06-28 19:47:11 UTC
Created attachment 90827 [details] [review]
v2: Rework padding/border
Comment 4 Bastien Nocera 2007-06-28 19:58:06 UTC
I don't think we need padding on the left (inside) side of sidebar, as we already have the paned doing the separation. Looks good otherwise.
Comment 5 Jan Arne Petersen 2007-06-28 21:40:11 UTC
Created attachment 90838 [details] [review]
v3: use 6 6 6 0 border
Comment 6 Bastien Nocera 2007-06-28 21:54:55 UTC
Looks great. Thanks for the patch.
Comment 7 Jan Arne Petersen 2007-06-28 22:28:50 UTC
2007-06-29  Jan Arne Petersen  <jpetersen@jpetersen.org>

	* data/playlist.glade:
	* src/ev-sidebar.c: (ev_sidebar_destroy),
	(ev_sidebar_combobox_changed_cb), (ev_sidebar_init),
	(ev_sidebar_get_current_page), (ev_sidebar_get_iter_for_page_id),
	(ev_sidebar_set_current_page), (ev_sidebar_add_page),
	(ev_sidebar_remove_page): Use a default GtkComboBox instead of the
	custom button menu combination (Closes #397776)