After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 395858 - Get rid of the unused mViewerStream
Get rid of the unused mViewerStream
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Browser plugin (obsolete)
2.17.x
Other Linux
: Normal normal
: ---
Assigned To: totem-browser-maint
totem-browser-maint
Depends on: 395793
Blocks:
 
 
Reported: 2007-01-12 17:49 UTC by Bastien Nocera
Modified: 2007-01-14 23:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
totem-remove-viewerstream.patch (2.71 KB, patch)
2007-01-12 17:50 UTC, Bastien Nocera
needs-work Details | Review

Description Bastien Nocera 2007-01-12 17:49:35 UTC
As it's not used any more.
Comment 1 Bastien Nocera 2007-01-12 17:50:28 UTC
Created attachment 80124 [details] [review]
totem-remove-viewerstream.patch
Comment 2 Christian Persch 2007-01-13 23:34:17 UTC
Why are you explicitly closing the stream before the SetPlaylist call? Right next we'll get DestroyStream where it'll be closed anyway.
Comment 3 Bastien Nocera 2007-01-14 13:44:50 UTC
(In reply to comment #2)
> Why are you explicitly closing the stream before the SetPlaylist call? Right
> next we'll get DestroyStream where it'll be closed anyway.

No reason, it's obviously wrong ;)
Comment 4 Bastien Nocera 2007-01-14 23:35:17 UTC
2007-01-14  Bastien Nocera  <hadess@hadess.net>

        * browser-plugin/totemPlugin.cpp:
        * browser-plugin/totemPlugin.h: remove the unused mViewerStream
        (Closes: #395858)