After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 395827 - Try to reduce remote accesses
Try to reduce remote accesses
Status: RESOLVED OBSOLETE
Product: totem-pl-parser
Classification: Core
Component: General
2.23.x
Other Linux
: Normal normal
: ---
Assigned To: totem-pl-parser-maint
totem-pl-parser-maint
Depends on:
Blocks:
 
 
Reported: 2007-01-12 16:22 UTC by Bastien Nocera
Modified: 2019-03-20 10:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
First pass (4.13 KB, patch)
2008-08-20 13:11 UTC, Bastien Nocera
needs-work Details | Review

Description Bastien Nocera 2007-01-12 16:22:12 UTC
$ ./test-parser http://localhost:12345/playlist.asx
###################### parsing ################

added URI 'http://localhost:12345/leopard.mov' with title 'empty' genre 'empty'
added URI 'http://localhost:12345/frontrow-music.mov' with title 'empty' genre 'empty'

Shows in the logs:
127.0.0.1 - - [12/Jan/2007:16:19:26 +0000] "GET /playlist.asx HTTP/1.1" 200 319 "-" "gnome-vfs/2.14.2 neon/0.25.4"
127.0.0.1 - - [12/Jan/2007:16:19:26 +0000] "GET /playlist.asx HTTP/1.1" 200 319 "-" "gnome-vfs/2.14.2 neon/0.25.4"
127.0.0.1 - - [12/Jan/2007:16:19:26 +0000] "GET /leopard.mov HTTP/1.1" 200 348892 "-" "gnome-vfs/2.14.2 neon/0.25.4"
127.0.0.1 - - [12/Jan/2007:16:19:26 +0000] "GET /frontrow-music.mov HTTP/1.1" 200 473716 "-" "gnome-vfs/2.14.2 neon/0.25.4"

It should only access playlist.asx once if possible.
Comment 1 Bastien Nocera 2008-05-24 12:30:51 UTC
Still the same problem:
$ cat root/access_log 
127.0.0.1 - - [24/May/2008:13:15:10 +0100] "GET /playlist.asx HTTP/1.1" 200 319 "-" "gvfs/0.2.3"
127.0.0.1 - - [24/May/2008:13:15:10 +0100] "GET /playlist.asx HTTP/1.1" 200 319 "-" "gvfs/0.2.3"

This is caused by _get_mime_type_with_data, which gets us the first few bytes of data to analyse, but then close the file, prompting us to reopen it later.

We should really be passing a triplet of:
- data read thus far (8k)
- len of data read thus far
- input stream, so we can read further, which would be empty if we finished reading the file
Comment 2 Bastien Nocera 2008-08-20 13:11:31 UTC
Created attachment 117049 [details] [review]
First pass

Still need to port all the parsers to use the existing data, probably just needs a helper function that'll either download everything from scratch, or continue an existing downlad.
Comment 3 Bastien Nocera 2008-10-08 16:46:29 UTC
This should be fixed.

1. Load http://www.yle.fi/elavaarkisto/?s=s&g=1&ag=4&t=410&a=6126
2. Click on the play button
3. Select "Jatka mahdollisista virheistä huolimatta"
Comment 4 Philip Withnall 2008-10-10 20:34:18 UTC
(In reply to comment #3)
> This should be fixed.
> 
> 1. Load http://www.yle.fi/elavaarkisto/?s=s&g=1&ag=4&t=410&a=6126
> 2. Click on the play button
> 3. Select "Jatka mahdollisista virheistä huolimatta"

Should the bug be closed then?
Comment 5 Bastien Nocera 2008-10-11 08:59:58 UTC
No, I meant that we should fix the bug to make the website above work.
Comment 6 GNOME Infrastructure Team 2019-03-20 10:38:19 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/totem-pl-parser/issues/7.